From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Move gdb-dlfcn.[ch] to gdbsupport/
Date: Wed, 21 Aug 2019 21:50:00 -0000 [thread overview]
Message-ID: <877e76kx35.fsf@tromey.com> (raw)
In-Reply-To: <20190821210820.25919-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 21 Aug 2019 17:08:20 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> I need to use 'gdb_dlopen' inside 'gdbsupport/', but it's not yet
Sergio> supported there. This commit moves 'gdb-dlfcn.[ch]' to 'gdbsupport/',
Sergio> which makes it available also on gdbserver.
Thanks for doing this.
It seems like a good idea to me.
Sergio> diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
Sergio> index 0009aac9f2..8d91f0d0e8 100644
Sergio> --- a/gdb/gdbserver/configure.ac
Sergio> +++ b/gdb/gdbserver/configure.ac
Sergio> @@ -88,7 +88,8 @@ AC_CHECK_HEADERS(termios.h sys/reg.h string.h dnl
Sergio> proc_service.h sys/procfs.h linux/elf.h dnl
Sergio> fcntl.h signal.h sys/file.h dnl
Sergio> sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
Sergio> - netinet/tcp.h arpa/inet.h)
Sergio> + netinet/tcp.h arpa/inet.h dnl
Sergio> + dlfcn.h)
I think it's better to add this check to gdbsupport/common.m4 (and
remove it from gdb's configure.ac).
Tom
next prev parent reply other threads:[~2019-08-21 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 21:08 Sergio Durigan Junior
2019-08-21 21:50 ` Tom Tromey [this message]
2019-08-22 1:15 ` Sergio Durigan Junior
2019-08-22 20:52 ` Sergio Durigan Junior
2019-08-23 17:05 ` Tom Tromey
2019-08-23 17:14 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e76kx35.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox