From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4248 invoked by alias); 21 Aug 2019 21:50:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4188 invoked by uid 89); 21 Aug 2019 21:50:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=UD:m4 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.192.34) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 21:49:53 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 1B3293B25 for ; Wed, 21 Aug 2019 16:49:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0YUJidD9z3Qi00YUJiJiY3; Wed, 21 Aug 2019 16:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4PsaZrGW+PMARm8AfEsQHK+hwc5gfT7hBiGExJCbWqg=; b=Xn6uqZxvWokcKur1XVaYEyCAwx fPH79MJm7XxZEeYgq+rtUl6nMVdlrKHsPiD/Q+zHt9tMRBKJKoNnGTDvOsFdeANazeZYF8MgOZyUR XDUwsq2+Ce/xRrA5O/XFx6ryg; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:42472 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i0YUJ-002l0V-J4; Wed, 21 Aug 2019 16:49:51 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] Move gdb-dlfcn.[ch] to gdbsupport/ References: <20190821210820.25919-1-sergiodj@redhat.com> Date: Wed, 21 Aug 2019 21:50:00 -0000 In-Reply-To: <20190821210820.25919-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 21 Aug 2019 17:08:20 -0400") Message-ID: <877e76kx35.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00518.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> I need to use 'gdb_dlopen' inside 'gdbsupport/', but it's not yet Sergio> supported there. This commit moves 'gdb-dlfcn.[ch]' to 'gdbsupport/', Sergio> which makes it available also on gdbserver. Thanks for doing this. It seems like a good idea to me. Sergio> diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac Sergio> index 0009aac9f2..8d91f0d0e8 100644 Sergio> --- a/gdb/gdbserver/configure.ac Sergio> +++ b/gdb/gdbserver/configure.ac Sergio> @@ -88,7 +88,8 @@ AC_CHECK_HEADERS(termios.h sys/reg.h string.h dnl Sergio> proc_service.h sys/procfs.h linux/elf.h dnl Sergio> fcntl.h signal.h sys/file.h dnl Sergio> sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl Sergio> - netinet/tcp.h arpa/inet.h) Sergio> + netinet/tcp.h arpa/inet.h dnl Sergio> + dlfcn.h) I think it's better to add this check to gdbsupport/common.m4 (and remove it from gdb's configure.ac). Tom