From: Andrew Burgess <aburgess@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Fix missing print frame when stepping out of function
Date: Tue, 31 Mar 2026 16:44:49 +0100 [thread overview]
Message-ID: <877bqsm2a6.fsf@redhat.com> (raw)
In-Reply-To: <fb23183d-884c-4203-b5c6-3ee41fcc4bef@suse.de>
Tom de Vries <tdevries@suse.de> writes:
> On 3/19/26 7:03 PM, Tom de Vries wrote:
>>> I think that it is worth at least investigating altering
>>> step_start_function to track the actual function, including inline
>>> functions, this seems like it would be a better fix. But if not then at
>>> least we'll understand why it's not the right solution.
>>
>> Hi,
>>
>> just a small update on this.
>>
>> I've given this a try ( https://github.com/vries/gdb/tree/gdb/fix-
>> missing-print-frame-when-stepping-out-of-function-2 ) and ran into
>> trouble with just one test-case, gdb.opt/inline-cmds.exp ).
>>
>> Basically, with current gdb we have:
>> ...
>> 63 x = 7;
>> (gdb) s
>> 64 y = 8; /* set mi break here */
>> (gdb) s
>> 66 result = func1 ();
>> (gdb)
>> ...
>> and with the patch series posted above:
>> ...
>> 63 x = 7;
>> (gdb) s
>> 64 y = 8; /* set mi break here */
>> (gdb) s
>> main () at /data/vries/gdb/leap-16-0/build/../../src/gdb/testsuite/
>> gdb.opt/inline-cmds.c:66
>> 66 result = func1 ();
>> (gdb)
>> ...
>>
>> There is some code somewhere that allows entry into an inline function
>> to happen in two steps, even if the pc stays the same inbetween, and
>> that code seems to interact with the solution in the patch series.
>>
>> I'll take a further look tomorrow.
>
> Hi Andrew,
>
> this estimate turned out to be somewhat optimistic, but I've taken a
> look today, and submitted a v2 with the RFC tag (
> https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html ),
> containing the analysis of the regression mentioned above.
I'll take a look.
Thanks,
Andrew
next prev parent reply other threads:[~2026-03-31 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 12:02 Tom de Vries
2026-03-18 14:29 ` Andrew Burgess
2026-03-19 18:03 ` Tom de Vries
2026-03-31 13:27 ` Tom de Vries
2026-03-31 15:44 ` Andrew Burgess [this message]
2026-03-31 13:32 ` Tom de Vries
2026-04-03 15:17 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bqsm2a6.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox