From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UX3bFSjsy2lm5wAAWB0awg (envelope-from ) for ; Tue, 31 Mar 2026 11:45:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=geCTBW8J; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4D5FE1E0BC; Tue, 31 Mar 2026 11:45:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6F0B1E04F for ; Tue, 31 Mar 2026 11:45:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E1B4E4B920C5 for ; Tue, 31 Mar 2026 15:45:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1B4E4B920C5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=geCTBW8J Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A53064B7A1E3 for ; Tue, 31 Mar 2026 15:44:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A53064B7A1E3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A53064B7A1E3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774971896; cv=none; b=Q8pb6/xmzaSH9BRMKvNpHxMp2U4exKtdHtt8cMT6PBlWIUoD8F+X29hxwLt7zVDkat676657N3Fdb7jRxR48GQtecASjG1VmJekj5Gr8u/LyUh0LEV2CbEiS8eh38mc0Nf+VSBIrc48oU4yfA/bfwZygcGBuAttM7FF95vpLXDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774971896; c=relaxed/simple; bh=/7jJJQTS7YIaND1jYSi759XlZs5e4Dp6Y2wrSTZQk7g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wOAvHCM5bX9i20cc5MrN4jqfG4R1/XpS08pf3DYwIxgESHASFYsawFDKeMKsp3S5QOMXKjGBDPjd63EXhjC0QTXININ4EzzB0Y61kPTnLcO6T/1zPjHkbWnV7yC/UqQOGxbSTWb1XPqEmsIB4KRBJ5XX0hI0WUXhvC2Ca4wsChc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A53064B7A1E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774971896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/7jJJQTS7YIaND1jYSi759XlZs5e4Dp6Y2wrSTZQk7g=; b=geCTBW8JzLb+TEfcxoDsLEqoV1eGedHjiutFoCy9lIOZSykp803i8ZkM5paNoAhKvrJsbJ ykDllNSbejKcWwil/sVFOPOVq88c793ibdBLLENeqkuw2HfrC1ycq7GX+QbFJmXqfuVl9q 6mivRNQha0IXImopCF9W7Lvb7cC7820= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-niFwymbAOZmLKtY-vIZvMA-1; Tue, 31 Mar 2026 11:44:54 -0400 X-MC-Unique: niFwymbAOZmLKtY-vIZvMA-1 X-Mimecast-MFC-AGG-ID: niFwymbAOZmLKtY-vIZvMA_1774971893 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso70401175e9.1 for ; Tue, 31 Mar 2026 08:44:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971892; x=1775576692; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LgbILZb/lpYn8jQe8ovXpLaRA/35TPbMb7WMxHMGuvg=; b=XJUc8uH/ARvKWszWkYFyoIGdBYje5i/Tgt0SzhCJXU5DWr9tMOo9QftbkcjCsBdS6O shrLPlynYzVg1htJwoAEiCs6uRF2gTECiYjdE7ziRMo9/6wktKSA6/QS2OvCPArwJe12 AxxwNHwtHce07k7eI1iuS8rsh3ewqQA7c20qmTKLr1cUQRCAV1C4KP4M7fEQjkf7E8QS A2ZcpYh/EirbcRoRe5/z9WodaIPvxnQkIi5G2RqhEI05A/Mu03gOS2+0GNmemA16jNA8 tDsByzduGO61F8sGvcNPYn6eAujrzB8hq4hxgB4Nlrp54f6kE9yDXxvyamzunMxsPmU1 e0Qg== X-Forwarded-Encrypted: i=1; AJvYcCW8Sl3gVhThZV+RwcoORO3YuH2mLhVnv6E7T0y29idfdtGT1h7HkUq49rCl2wrtHx+5IaGK6kKgu+m5Mg==@sourceware.org X-Gm-Message-State: AOJu0Yx4UG6+jV40ve7C42DMIMiujb1117vAll2HVcehiJW64kGnpqRv uXbkwnBSCPuxT/smLxOgTyn/vVMp07QZ+tVIKkLsrATPMkuCmNIJvRxC82KnSpR4dSsTArLxJP5 O86kQtGFei8HzmhNRB4PvECFA/4TDOXw3p7eSEslYTYJMriwLVKKA09N/byG5RB1OLZuleMs= X-Gm-Gg: ATEYQzyZO0ZVZq+4uaVMfdV4f/u0rurtrPafIj5c/yTDfaEKvpIyOiaBjiadtjuMwnW n6shel9tw32LAcKKJ367017/D6EnXJSVWEF/Yeg0OGtSzRB1M3+4OPHP9AXk65k3QGWz4GTXvhM 46CalgLCh/A75WJawTy7lkalCzLiNZHNVviy17AWtM1OT94wI7+OovsQy+SN4hnOHaeochx2CCK MeJUOnxuy3GwYPHVE7horesa8d3gguihMurNN+5+NS/0kE7YpRaxefN4BYVM4gBWxc34nwJ25HC xYG8uQzh6JUQruo3F/xCpE9JQMBErV/Ls+2u29HTXWpLFivaOnlExBtBMeSWUhBjeTVyupn8po2 V3MiGLUeJYylrNtol X-Received: by 2002:a05:600c:8b63:b0:482:f564:d613 with SMTP id 5b1f17b1804b1-48727eafa46mr260489265e9.15.1774971892133; Tue, 31 Mar 2026 08:44:52 -0700 (PDT) X-Received: by 2002:a05:600c:8b63:b0:482:f564:d613 with SMTP id 5b1f17b1804b1-48727eafa46mr260488565e9.15.1774971891635; Tue, 31 Mar 2026 08:44:51 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48880d864b7sm10589155e9.3.2026.03.31.08.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:50 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Fix missing print frame when stepping out of function In-Reply-To: References: <20260312120211.3806600-1-tdevries@suse.de> <871phh6wir.fsf@redhat.com> <9e466544-aca0-4a0e-89fe-0221dfb5f7ed@suse.de> Date: Tue, 31 Mar 2026 16:44:49 +0100 Message-ID: <877bqsm2a6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DmQJnRKrEqNciTttS7temwQi1bv-_TlNvJiphzGisLg_1774971893 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 3/19/26 7:03 PM, Tom de Vries wrote: >>> I think that it is worth at least investigating altering >>> step_start_function to track the actual function, including inline >>> functions, this seems like it would be a better fix.=C2=A0 But if not t= hen at >>> least we'll understand why it's not the right solution. >>=20 >> Hi, >>=20 >> just a small update on this. >>=20 >> I've given this a try ( https://github.com/vries/gdb/tree/gdb/fix-=20 >> missing-print-frame-when-stepping-out-of-function-2 ) and ran into=20 >> trouble with just one test-case, gdb.opt/inline-cmds.exp ). >>=20 >> Basically, with current gdb we have: >> ... >> 63=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 x =3D 7; >> (gdb) s >> 64=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 y =3D 8; /* set mi break here */ >> (gdb) s >> 66=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 result =3D func1 (); >> (gdb) >> ... >> and with the patch series posted above: >> ... >> 63=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 x =3D 7; >> (gdb) s >> 64=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 y =3D 8; /* set mi break here */ >> (gdb) s >> main () at /data/vries/gdb/leap-16-0/build/../../src/gdb/testsuite/=20 >> gdb.opt/inline-cmds.c:66 >> 66=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 result =3D func1 (); >> (gdb) >> ... >>=20 >> There is some code somewhere that allows entry into an inline function= =20 >> to happen in two steps, even if the pc stays the same inbetween, and=20 >> that code seems to interact with the solution in the patch series. >>=20 >> I'll take a further look tomorrow. > > Hi Andrew, > > this estimate turned out to be somewhat optimistic, but I've taken a=20 > look today, and submitted a v2 with the RFC tag (=20 > https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html ),=20 > containing the analysis of the regression mentioned above. I'll take a look. Thanks, Andrew