From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove #ifdef from cooked-index-entry.c
Date: Wed, 28 Oct 2026 15:23:17 -0600 [thread overview]
Message-ID: <877bj1pliy.fsf@tromey.com> (raw)
In-Reply-To: <f900b513-33e6-480b-bb0a-adbaa02090ba@simark.ca> (Simon Marchi's message of "Wed, 28 Oct 2026 13:33:31 -0400")
Simon> For my curiosity, can you explain why constexpr was needed (or
Simon> useful) in the first place?
I added a note to the commit message but basically:
Simon> The commit that added it is:
Simon> https://gitlab.com/gnutools/binutils-gdb/-/commit/2e724489260d02a528591eaea4710ce5aeeee0e8
Simon> but it doesn't talk about that.
... the old code called "munge ('<')" which is a constant.
Though perhaps that was wishful thinking and/or maybe an older patch did
something else.
Tom
prev parent reply other threads:[~2026-10-28 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 17:23 Tom Tromey
2026-10-28 17:33 ` Simon Marchi
2026-10-28 21:23 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bj1pliy.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox