From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EYB9AeJn4mqWAwQAWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 17:23:46 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VtxPt/Nb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EC454378002; Wed, 28 Oct 2026 17:23:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4927E1E007 for ; Wed, 28 Oct 2026 17:23:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 58A2B4BA2E1B for ; Wed, 28 Oct 2026 21:23:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58A2B4BA2E1B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VtxPt/Nb Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 341254BA2E14 for ; Wed, 28 Oct 2026 21:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 341254BA2E14 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 341254BA2E14 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793222599; cv=none; b=KSs/exD4m/soUW+2wiMEY8yfA1siRxlx6bFz40yZUhNnr3ryKVmUJdRI+qnfshbatm6Qc+srrWqj0SGsUNMJNdg/3R5y0OSw/wHlEVYTHk4ggnasHGEoZ8bZlmoH021N1w6d43Fk6ZBS7X6mUDMc3PCXXLy5UGzzbJVQoNm+s4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793222599; c=relaxed/simple; bh=J/Ay2HeXvqlo7g10vfR+5TBOv1bm+/7dT00OjFFHQPs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=M9nTP42dWsdy9tWpk7CTB9XJrl6uh9//sOC2pMPJmir5bnm9lOgUQItLrNw1oMajkhLq6gZ4FP0uXzzYSoOqxRy49XiMJ7QVA69DdDOPQVC9Efrtm0DbNO2YSVDK3jQOe4YOMqcsgRCv+VhF+ihQ29fHroh8teaYayfSRcxsGu4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VtxPt/Nb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 341254BA2E14 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-8446af403b5so922382a34.2 for ; Wed, 28 Oct 2026 14:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1793222598; x=1793827398; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=J/Ay2HeXvqlo7g10vfR+5TBOv1bm+/7dT00OjFFHQPs=; b=VtxPt/NbU7Re3EndWTUOamVBXwqeKslWXLqUMyjQiQOk30ulAU/ov2e7L0of0EJbIC e6AYiFdU6woQN8p42EloUhP/gq9ro0HMZf2WwuyoyZoqFsrN+NCd7/PvpRxi17z1Ss0r u3KOnEQnveyLpCCZ6+1TyAxxhKtGtki6PLD0X0ruGTkIjDi6CBq7PXYSxC4zeyUaxVd2 r2EeJBD0Srwosd/pT7PIdDsBX7dP/7Fg7SPm+I4Pf4ISsPNM4s1Z9qaEUg6a16BYYvmf elphiPcSjZmj+t5jWx78Fgk0URpylKsOs6MlXDc/o0Vn0Y9/ZL4Zzb8pV4lA7aLPVXAf +YIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793222598; x=1793827398; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=J/Ay2HeXvqlo7g10vfR+5TBOv1bm+/7dT00OjFFHQPs=; b=CQnMtHHjk0K4QqLyWdGRQyObSd7zr23tqpbnXLilMVBntPSR5Fr5Q0BXDCQr+a8oNv YVbLNlvF/Sl9hD5wQj2hucSflZXqgjpRx3B/kp7CbHVONI/hp59Li319gzmOjXtVlfmB T44jiSAnZ6BnUdz61Au9ZdE+QfdQ6hfUk45zaeeDz9OtSraL7m32NgIKEnjPjmijvGR9 TXd7u/r+wrQBs8cJn1nNBsQgbavrkMWRXt+1ni/+Q4U/Y6jWzGdl3e9LwrbpNyZuAP/R 4HKUAMu7gJzuEO79mPArHNJHsNERnY6+MBexkIF3+ToLXFSJLb+PQTyRGIKTl1HvbDy0 Yn2g== X-Forwarded-Encrypted: i=1; AKwUvBwsXKoKCM2/6T2yZcQMWDFnqBoCl9y0LXatZ2UDWlqLPBsf4OEAFTH/st0l9pwkSlSXW/fjMiccaZTo8g==@sourceware.org X-Gm-Message-State: AFq9FYIe1MD93uAu0q49+IJYvSNHfJnIX2Z3GE1jbSVytSDOdg74JRQA 1p/M5V2W6flyS/bXYpCa5O7QN6HzoABsZ5M8rY/xSuUpvQ2AFKFE2b3vJxCisgc+6974QU8kJFQ htWEPJg== X-Gm-Gg: AYBFou2GI3AzqC8/g0zPduBHfjFNg2/niEnzgbgdU5MpyoxiNncN8dvTF0Buc+2W0ty ULqG3DPUqf+7FRJFq/hbjJsTyPAnd2B+KbQjW81bGyBypli4ANQ/G07t3jB5i8A50qrjNptJPtz iRMnIZ5hhahHVMk+EgwhFbIyDFnj0XXyeEVKhBtSesEWxBv9rMpbz9rQOqMvntaUdhumZe584bz XWw5+Nmej1ZJa8UlMa9CrMZxULVHihwBjYUgAfArr5SRfct6DIllcCj0pdZ7GcEhTtHOwLRSRmr iZCrSh3bFBA6+1ad7b3lKWMs9oe62mvx1pO9oYDo3HL7W/IHoya91npdljKDgjl3UiBCucL3NwU OcLJyduLRIxfBAi5DN+DO1DYcbrR3TuMtiknBSIPHhZi3gxkkR4PNUVNy72GFTbVm39fi6QZ1hI UQSEKaaHHYOZdfLEaNkWPoyxikGp1E2WmUdQfA26OxNUR0uIoam2dX7d9FQIOnJyDApKQFt/jDc FKwV61rbEE/94RL2j4WC1IX5PlhWFHEACW+y4I51dRsn+D5O2EE6Lzoe16DTXLjcTv9DO/FL19l h2ELK00h5rK3PPI1bFy2tB1JnXBTbWWH98iEQVsTTIDzR4UdN5Q= X-Received: by 2002:a05:6808:448b:b0:4d6:9293:9b54 with SMTP id 5614622812f47-56384595d98mr2560262b6e.60.1793222598563; Wed, 28 Oct 2026 14:23:18 -0700 (PDT) Received: from bapiya (97-122-110-129.hlrn.qwest.net. [97.122.110.129]) by smtp.gmail.com with ESMTPSA id 5614622812f47-563ee386839sm832617b6e.0.2026.10.28.14.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 14:23:18 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove #ifdef from cooked-index-entry.c In-Reply-To: (Simon Marchi's message of "Wed, 28 Oct 2026 13:33:31 -0400") References: <20261028172301.1376846-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 28 Oct 2026 15:23:17 -0600 Message-ID: <877bj1pliy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> For my curiosity, can you explain why constexpr was needed (or Simon> useful) in the first place? I added a note to the commit message but basically: Simon> The commit that added it is: Simon> https://gitlab.com/gnutools/binutils-gdb/-/commit/2e724489260d02a528591eaea4710ce5aeeee0e8 Simon> but it doesn't talk about that. ... the old code called "munge ('<')" which is a constant. Though perhaps that was wishful thinking and/or maybe an older patch did something else. Tom