Re: [PATCH] configure: Support --with-zstd=PATH

[Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>]

On 2026-09-29 03:55, Simon Marchi wrote:
> 
> 
> On 2026-09-27 07:48, Torbjörn SVENSSON wrote:
>> Hi,
>>
>> I noticed that the configure scripts in this repository does not use the path
>> given to the --with-zstd option, while for example GCC does.  This patch adds
>> the missing logic in config/zstd.m4 and regenerat the configure files with that
>> change.
>>
>> Also worth noting is that I see blocks like below (manually excluded in this
>> patch) when I run autoconf2.69:
>>
>> -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
>> +#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) << 31))
> 
> In which directory do you see that?
> 
> Normally, this builder here re-generates a bunch of things, including
> the configure machinery, and errors out if it sees any difference.  Make
> sure you use an upstream autoconf build, not a build from a distro.

Ah, my bad!
I have a vanilla autoconf 2.69, but apparently, it had got lost on my $PATH.

With the one from the distro, I got the changes for:
bfd/configure
binutils/configure
gas/configure
gdb/configure
ld/configure

> 
> https://builder.sourceware.org/buildbot/#/builders/270
> 
> Simon

Kind regards,
Torbjörn