From: Simon Marchi <simark@simark.ca>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] configure: Support --with-zstd=PATH
Date: Mon, 28 Sep 2026 21:55:38 -0400 [thread overview]
Message-ID: <d2612532-b6d0-4439-a106-ada9ad987501@simark.ca> (raw)
In-Reply-To: <20260927115704.1214794-1-torbjorn.svensson@foss.st.com>
On 2026-09-27 07:48, Torbjörn SVENSSON wrote:
> Hi,
>
> I noticed that the configure scripts in this repository does not use the path
> given to the --with-zstd option, while for example GCC does. This patch adds
> the missing logic in config/zstd.m4 and regenerat the configure files with that
> change.
>
> Also worth noting is that I see blocks like below (manually excluded in this
> patch) when I run autoconf2.69:
>
> -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
> +#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) << 31))
In which directory do you see that?
Normally, this builder here re-generates a bunch of things, including
the configure machinery, and errors out if it sees any difference. Make
sure you use an upstream autoconf build, not a build from a distro.
https://builder.sourceware.org/buildbot/#/builders/270
Simon
prev parent reply other threads:[~2026-09-29 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 11:48 Torbjörn SVENSSON
2026-09-29 1:55 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2612532-b6d0-4439-a106-ada9ad987501@simark.ca \
--to=simark@simark.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox