Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jim Meyering <jim@meyering.net>
Cc: gdb-patches@sourceware.org
Subject: Re: many typo fixes
Date: Fri, 08 Jun 2012 17:37:00 -0000	[thread overview]
Message-ID: <8762b1emhf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87k3zut5xx.fsf@rho.meyering.net> (Jim Meyering's message of	"Wed, 30 May 2012 10:43:22 +0200")

>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:

Jim> Massaging the output of http://github.com/lyda/misspell-check,

Jim> Also, beware of the few suggested transforms that map from all-caps
Jim> like "LENGHT" to leading-cap-only "Length".

Jim> This is deliberately just an FYI, not an actual patch.
Jim> I'll let someone else write the actual patch.

I looked at this a little today.

It needed some further tweaks, as it is also applying patches to the
code, in some cases breaking it.  At least, that is the case when I ran
it myself -- I don't see the specific problem I noticed in your list,
which is odd since I just used your script...

Anyway once I did that I realized I didn't really trust the output, and
I didn't really want to do a detailed review the whole patch by hand.
It's rather large and boring.  You can't rely on the compiler because
not every file is compiled on every host...

So I think I'm going to drop it.  If you want to make a patch for gdb,
though, ... :)

Jim> sed -i '3279s!dependant!dependent!' bfd/aoutx.h
[...]
Jim> sed -i '54s!layed!laid!' config-ml.in
[...]
Jim> sed -i '491s!accomodate!accommodate!' cpu/frv.opc
[...]
Jim> sed -i '84s!upto!up to!' readline/histexpand.c
[...]

BFD and CPU changes should go to binutils.
config-ml.in is canonically maintained in gcc, then sync'd.
readline fixes should go upstream.

Tom


  reply	other threads:[~2012-06-08 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  8:44 Jim Meyering
2012-06-08 17:37 ` Tom Tromey [this message]
2012-06-08 17:51   ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762b1emhf.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox