From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19030 invoked by alias); 8 Jun 2012 17:37:28 -0000 Received: (qmail 18990 invoked by uid 22791); 8 Jun 2012 17:37:25 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 17:34:41 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q58HYcou009053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Jun 2012 13:34:38 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q58HYbxl009704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Jun 2012 13:34:37 -0400 From: Tom Tromey To: Jim Meyering Cc: gdb-patches@sourceware.org Subject: Re: many typo fixes References: <87k3zut5xx.fsf@rho.meyering.net> Date: Fri, 08 Jun 2012 17:37:00 -0000 In-Reply-To: <87k3zut5xx.fsf@rho.meyering.net> (Jim Meyering's message of "Wed, 30 May 2012 10:43:22 +0200") Message-ID: <8762b1emhf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00240.txt.bz2 >>>>> "Jim" == Jim Meyering writes: Jim> Massaging the output of http://github.com/lyda/misspell-check, Jim> Also, beware of the few suggested transforms that map from all-caps Jim> like "LENGHT" to leading-cap-only "Length". Jim> This is deliberately just an FYI, not an actual patch. Jim> I'll let someone else write the actual patch. I looked at this a little today. It needed some further tweaks, as it is also applying patches to the code, in some cases breaking it. At least, that is the case when I ran it myself -- I don't see the specific problem I noticed in your list, which is odd since I just used your script... Anyway once I did that I realized I didn't really trust the output, and I didn't really want to do a detailed review the whole patch by hand. It's rather large and boring. You can't rely on the compiler because not every file is compiled on every host... So I think I'm going to drop it. If you want to make a patch for gdb, though, ... :) Jim> sed -i '3279s!dependant!dependent!' bfd/aoutx.h [...] Jim> sed -i '54s!layed!laid!' config-ml.in [...] Jim> sed -i '491s!accomodate!accommodate!' cpu/frv.opc [...] Jim> sed -i '84s!upto!up to!' readline/histexpand.c [...] BFD and CPU changes should go to binutils. config-ml.in is canonically maintained in gcc, then sync'd. readline fixes should go upstream. Tom