Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Nicolas Blanc <nicolas.blanc@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] remove-symbol-file
Date: Wed, 24 Apr 2013 09:22:00 -0000	[thread overview]
Message-ID: <8761zdow5j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1366098721-18302-1-git-send-email-nicolas.blanc@intel.com>	(Nicolas Blanc's message of "Tue, 16 Apr 2013 09:51:57 +0200")

>>>>> "Nicolas" == Nicolas Blanc <nicolas.blanc@intel.com> writes:

Nicolas> 1) The remove-symbol-file command from Apple takes as parameter
Nicolas>    the file to remove whereas this implementation requires the load
Nicolas>    address of the file. Hence, this command is able to unload
Nicolas>    symbol for files that have been loaded multiple times.

Nicolas> 2) This implementation sends a notification when an object file is
Nicolas>    deleted. The notification mechanism simplifies the implementation of
Nicolas>    the command because it is then the responsibility of the observers
Nicolas>    to clean dangling references. GDB removes shared libraries in this
Nicolas>    way already.

This sounds reasonable to me.

I wonder if it would be advisable to design the syntax so that we can
have remove-symbol-file also accept a file name, perhaps later if we
decide we want that.

Tom


  parent reply	other threads:[~2013-04-23 20:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 11:22 Nicolas Blanc
2013-04-16 11:51 ` [PATCH 2/3] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-04-24 12:18   ` Tom Tromey
2013-04-24 12:18     ` Tom Tromey
2013-04-16 12:18 ` [PATCH 1/3] Command remove-symbol-file Nicolas Blanc
2013-04-16 13:25 ` [PATCH 1/3] Added command remove-symbol-file Nicolas Blanc
2013-04-22 13:32   ` Yao Qi
2013-04-24 18:54   ` Tom Tromey
2013-04-25 19:24     ` Blanc, Nicolas
2013-04-25 20:07       ` Tom Tromey
2013-04-26 14:13       ` Yao Qi
2013-04-26 20:23   ` Pedro Alves
2013-04-30  7:30     ` Blanc, Nicolas
2013-04-30  9:28       ` Pedro Alves
2013-04-30 16:53         ` Blanc, Nicolas
2013-05-08 17:56           ` Pedro Alves
2013-05-28 11:25             ` Blanc, Nicolas
2013-04-16 14:18 ` [PATCH 3/3] Documentation for the remove-symbol-file command Nicolas Blanc
2013-04-16 15:12   ` Eli Zaretskii
2013-04-24  9:22 ` Tom Tromey [this message]
2013-04-24 20:40   ` [PATCH 0/3] remove-symbol-file Blanc, Nicolas
2013-04-24 20:49     ` Pedro Alves
2013-04-25 17:25       ` Blanc, Nicolas
2013-04-26 19:13         ` Pedro Alves
2013-04-24 17:46 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761zdow5j.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nicolas.blanc@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox