* New ARI warning Fri Oct 18 01:51:13 UTC 2013 in -D 2013.10.18.00.00.15
@ 2013-10-18 1:51 GDB Administrator
2013-10-18 2:10 ` Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: GDB Administrator @ 2013-10-18 1:51 UTC (permalink / raw)
To: gdb-patches
47a48
> gdb/c-varobj.c:534: code: OP eol: Do not use &&, or || at the end of a line
gdb/c-varobj.c:534: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
854d854
< gdb/varobj.c:3494: code: OP eol: Do not use &&, or || at the end of a line
gdb/varobj.c:3494: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: New ARI warning Fri Oct 18 01:51:13 UTC 2013 in -D 2013.10.18.00.00.15
2013-10-18 1:51 New ARI warning Fri Oct 18 01:51:13 UTC 2013 in -D 2013.10.18.00.00.15 GDB Administrator
@ 2013-10-18 2:10 ` Yao Qi
2013-10-18 10:15 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2013-10-18 2:10 UTC (permalink / raw)
To: gdb-patches
On 10/18/2013 09:51 AM, GDB Administrator wrote:
> 47a48
>> >gdb/c-varobj.c:534: code: OP eol: Do not use &&, or || at the end of a line
> gdb/c-varobj.c:534: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
> 854d854
> < gdb/varobj.c:3494: code: OP eol: Do not use &&, or || at the end of a line
> gdb/varobj.c:3494: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
Fixed by this patch.
--
Yao (é½å°§)
gdb:
2013-10-18 Yao Qi <yao@codesourcery.com>
* c-varobj.c (cplus_number_of_children): Fix indentation.
Index: c-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/c-varobj.c,v
retrieving revision 1.1
diff -u -r1.1 c-varobj.c
--- c-varobj.c 17 Oct 2013 13:28:36 -0000 1.1
+++ c-varobj.c 18 Oct 2013 02:04:10 -0000
@@ -531,8 +531,8 @@
}
adjust_value_for_child_access (&value, &type, NULL,
lookup_actual_type);
- if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
- ((TYPE_CODE (type)) == TYPE_CODE_UNION))
+ if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT)
+ || ((TYPE_CODE (type)) == TYPE_CODE_UNION))
{
int kids[3];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: New ARI warning Fri Oct 18 01:51:13 UTC 2013 in -D 2013.10.18.00.00.15
2013-10-18 2:10 ` Yao Qi
@ 2013-10-18 10:15 ` Andreas Schwab
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2013-10-18 10:15 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
Yao Qi <yao@codesourcery.com> writes:
> On 10/18/2013 09:51 AM, GDB Administrator wrote:
>> 47a48
>>> >gdb/c-varobj.c:534: code: OP eol: Do not use &&, or || at the end of a line
>> gdb/c-varobj.c:534: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
>> 854d854
>> < gdb/varobj.c:3494: code: OP eol: Do not use &&, or || at the end of a line
>> gdb/varobj.c:3494: if (((TYPE_CODE (type)) == TYPE_CODE_STRUCT) ||
>
> Fixed by this patch.
There are also a lot of redundant parens.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-18 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-18 1:51 New ARI warning Fri Oct 18 01:51:13 UTC 2013 in -D 2013.10.18.00.00.15 GDB Administrator
2013-10-18 2:10 ` Yao Qi
2013-10-18 10:15 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox