Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [PATCH] Carry the gnulib getcwd backport as a patch
Date: Tue, 18 Sep 2018 21:39:00 -0000	[thread overview]
Message-ID: <875zz2scyg.fsf@tromey.com> (raw)
In-Reply-To: <20180918212124.5851-1-simon.marchi@ericsson.com> (Simon Marchi's	message of "Tue, 18 Sep 2018 21:21:36 +0000")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> Instead, I suggest we carry that backport as a patch applied by the
Simon> update-gnulib.sh script after running the import tool.  It will make it
Simon> clear what backport or local modification we have and should make
Simon> running update-gnulib.sh give a reproducible result.

This seems like a good idea to me.

Simon> +# Apply our local patches.
Simon> +apply_patches ()

This should probably be "apply_patch" since it just applies a single patch.

Also there is a comment near the top of update-gnulib.sh:

    # This script will also make a number of other verifications:
    #   . The gnulib version (it should match $GNULIB_COMMIT_SHA1).
    #   . The correct versions of the auto-tools that are used to
    #     regenerate the various scripts and Makefiles are on the PATH.

I think an addition here about updating the patches would be good.

Tom


  parent reply	other threads:[~2018-09-18 21:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 21:21 Simon Marchi
2018-09-18 21:33 ` John Baldwin
2018-09-18 21:39 ` Tom Tromey [this message]
2018-09-18 21:49   ` Simon Marchi
     [not found]     ` <87woriqxmj.fsf@tromey.com>
2018-09-18 21:59       ` Simon Marchi
2018-09-19  2:42         ` Sergio Durigan Junior
2018-09-19  3:49           ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zz2scyg.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox