From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18779 invoked by alias); 18 Sep 2018 21:39:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18494 invoked by uid 89); 18 Sep 2018 21:38:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Makefiles, verifications, our X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 21:38:58 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id BF886A4C3 for ; Tue, 18 Sep 2018 16:38:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2NhogBWs6aSey2Nhsgbk3z; Tue, 18 Sep 2018 16:38:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YD3og/mAAwubvlX93qONqokkVy9hlj13s/NnzDCTNhI=; b=vSHp3mRtlbTEnQmtph32hQo+It mpWuhB2zuShEK7/DJpNOjkexZHDLwmsoOp+ve9zszG9gzHxzJv4g43fhdf8NOOE93OIxXF9OKPy3F Vp2P9deEaQ/xsU5k46An8qaZI; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:53674 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2Nho-003MyT-5u; Tue, 18 Sep 2018 16:38:48 -0500 From: Tom Tromey To: Simon Marchi Cc: "gdb-patches\@sourceware.org" , Sergio Durigan Junior Subject: Re: [PATCH] Carry the gnulib getcwd backport as a patch References: <20180918212124.5851-1-simon.marchi@ericsson.com> Date: Tue, 18 Sep 2018 21:39:00 -0000 In-Reply-To: <20180918212124.5851-1-simon.marchi@ericsson.com> (Simon Marchi's message of "Tue, 18 Sep 2018 21:21:36 +0000") Message-ID: <875zz2scyg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00660.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Instead, I suggest we carry that backport as a patch applied by the Simon> update-gnulib.sh script after running the import tool. It will make it Simon> clear what backport or local modification we have and should make Simon> running update-gnulib.sh give a reproducible result. This seems like a good idea to me. Simon> +# Apply our local patches. Simon> +apply_patches () This should probably be "apply_patch" since it just applies a single patch. Also there is a comment near the top of update-gnulib.sh: # This script will also make a number of other verifications: # . The gnulib version (it should match $GNULIB_COMMIT_SHA1). # . The correct versions of the auto-tools that are used to # regenerate the various scripts and Makefiles are on the PATH. I think an addition here about updating the patches would be good. Tom