From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Minor Ada task cleanups
Date: Tue, 19 Feb 2019 19:25:00 -0000 [thread overview]
Message-ID: <875ztftwbo.fsf@tromey.com> (raw)
In-Reply-To: <20190217145708.GC8537@adacore.com> (Joel Brobecker's message of "Sun, 17 Feb 2019 18:57:08 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Since this code is used on all platforms and native platforms
Joel> in particular have a lot more testcases that exercise this code,
Joel> it would be nice to exercise it both with the build-bot and
Joel> AdaCore's testsuite.
I ran it through the buildbot as well.
Fedora's buildbot install is broken :-(
https://bugzilla.redhat.com/show_bug.cgi?id=1661951
I had previous made a virtualenv for buildbot, but today the
straightforward approach didn't work. Here's the recipe I ended up
using:
cd ~
python2 -m virtualenv buildbot
. buildbot/bin/activate
pip install buildbot==1.7.0
Joel> Other than that, the patch looks good to me; if the patch with
Joel> the change I suggested passes testing, it's OK to push.
I made the change & I'm going to check it in momentarily.
Tom
prev parent reply other threads:[~2019-02-19 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 21:23 Tom Tromey
2019-02-17 14:57 ` Joel Brobecker
2019-02-19 13:13 ` Tom Tromey
2019-02-19 19:25 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ztftwbo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox