From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56541 invoked by alias); 19 Feb 2019 19:25:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56524 invoked by uid 89); 19 Feb 2019 19:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=adacore's, adacores, AdaCore's, AdaCores X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.204) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Feb 2019 19:25:18 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 2E8C5E95589 for ; Tue, 19 Feb 2019 13:25:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id wB12gTGf32qH7wB12g02GI; Tue, 19 Feb 2019 13:25:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9Ty3jvJfqiP/eNaFS45NJSPlWv8fkf7V/539JCrN5b0=; b=XP6u+5+Ey5GpTDsq5OzHIBpCbG SEKRl+N7uqeWXcKfEC9rBtvRjB35teE+TccpYzaQw+d7xMX/LgMygG1gfgszDoVCgvwm1PZsL3frx XzNDGK3pTYGrJQuable+hyD4j; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:38002 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gwB12-002mpS-Gg; Tue, 19 Feb 2019 13:25:16 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Minor Ada task cleanups References: <20190215212253.25409-1-tromey@adacore.com> <20190217145708.GC8537@adacore.com> Date: Tue, 19 Feb 2019 19:25:00 -0000 In-Reply-To: <20190217145708.GC8537@adacore.com> (Joel Brobecker's message of "Sun, 17 Feb 2019 18:57:08 +0400") Message-ID: <875ztftwbo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00307.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Since this code is used on all platforms and native platforms Joel> in particular have a lot more testcases that exercise this code, Joel> it would be nice to exercise it both with the build-bot and Joel> AdaCore's testsuite. I ran it through the buildbot as well. Fedora's buildbot install is broken :-( https://bugzilla.redhat.com/show_bug.cgi?id=1661951 I had previous made a virtualenv for buildbot, but today the straightforward approach didn't work. Here's the recipe I ended up using: cd ~ python2 -m virtualenv buildbot . buildbot/bin/activate pip install buildbot==1.7.0 Joel> Other than that, the patch looks good to me; if the patch with Joel> the change I suggested passes testing, it's OK to push. I made the change & I'm going to check it in momentarily. Tom