Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Ali Tamur via gdb-patches" <gdb-patches@sourceware.org>
Cc: Ali Tamur <tamur@google.com>
Subject: Re: [PATCH] Support for DW_OP_addrx and DW_FORM_addrx tags
Date: Mon, 08 Apr 2019 20:28:00 -0000	[thread overview]
Message-ID: <875zro6y43.fsf@tromey.com> (raw)
In-Reply-To: <CAH=Am=6aLScyTBFjNHdBg4KrjkiXrsw1oz7eJE1bhEcbYQdvzA@mail.gmail.com>	(Ali Tamur via gdb-patches's message of "Wed, 3 Apr 2019 17:50:54	-0700")

>>>>> "Ali" == Ali Tamur via gdb-patches <gdb-patches@sourceware.org> writes:

Ali> DW_OP_addrx is the new name of DW_OP_GNU_addr_index, and DW_FORM_addrx
Ali> is the name of DW_FORM_addr_index in the Dwarf 5 standard. This is a small
Ali> step towards supporting Dwarf 5 in gdb.

Thanks for doing this.

The patch seemed to be a bit mangled by some mailer somewhere.  However,
it looks fine to me.

Do you have commit access to gdb?  If not, contact me off-list to set up
write-after-approval permission.

Ali> Note: I could not find any tests specifically for *_GNU_addr_index, and
Ali> I did not add any new tests, please advise.

I think this stuff was previously tested by using the script
gdb/contrib/cc-with-tweaks.sh.  Also see gdb/testsuite/boards/cc-with-tweaks.exp
and maybe gdb/testsuite/boards/fission.exp (?).

Tom


      parent reply	other threads:[~2019-04-08 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04  0:51 Ali Tamur via gdb-patches
2019-04-08 20:04 ` Ali Tamur via gdb-patches
2019-04-08 20:28 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zro6y43.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tamur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox