From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70273 invoked by alias); 8 Apr 2019 20:28:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70265 invoked by uid 89); 8 Apr 2019 20:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=mailer, somewhere X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Apr 2019 20:27:59 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D3513F926 for ; Mon, 8 Apr 2019 15:27:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Das1hxXkn90onDas1hAEbG; Mon, 08 Apr 2019 15:27:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gs6GyackxGQDHSe5Cp6uej4kTdd9Eqm6dbLE6YKCQ8U=; b=eQtpt9AKgy/IBnvT+6isqX1QWX dSCPl852Wq4d8pzjp6atp80qOGjwvCu33JqU5rxAbFdybhVs8D7a4uQK2p8Z/g4ityMVa9W8QFN0l gxU1XhJ1/+buTl8iFFuetgjEf; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:36982 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hDas1-001yMw-LF; Mon, 08 Apr 2019 15:27:57 -0500 From: Tom Tromey To: "Ali Tamur via gdb-patches" Cc: Ali Tamur Subject: Re: [PATCH] Support for DW_OP_addrx and DW_FORM_addrx tags References: Date: Mon, 08 Apr 2019 20:28:00 -0000 In-Reply-To: (Ali Tamur via gdb-patches's message of "Wed, 3 Apr 2019 17:50:54 -0700") Message-ID: <875zro6y43.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00133.txt.bz2 >>>>> "Ali" == Ali Tamur via gdb-patches writes: Ali> DW_OP_addrx is the new name of DW_OP_GNU_addr_index, and DW_FORM_addrx Ali> is the name of DW_FORM_addr_index in the Dwarf 5 standard. This is a small Ali> step towards supporting Dwarf 5 in gdb. Thanks for doing this. The patch seemed to be a bit mangled by some mailer somewhere. However, it looks fine to me. Do you have commit access to gdb? If not, contact me off-list to set up write-after-approval permission. Ali> Note: I could not find any tests specifically for *_GNU_addr_index, and Ali> I did not add any new tests, please advise. I think this stuff was previously tested by using the script gdb/contrib/cc-with-tweaks.sh. Also see gdb/testsuite/boards/cc-with-tweaks.exp and maybe gdb/testsuite/boards/fission.exp (?). Tom