From: Tom Tromey <tom@tromey.com>
To: Wei-min Pan <weimin.pan@oracle.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: CTF support
Date: Fri, 26 Jul 2019 02:09:00 -0000 [thread overview]
Message-ID: <875znpk0mx.fsf@tromey.com> (raw)
In-Reply-To: <389644b2-5fb4-b963-f362-e9a2e34b44ac@oracle.com> (Wei-min Pan's message of "Thu, 25 Jul 2019 17:13:01 -0700")
>> If libctf were not built before gdb, gdb build would have failed
>> which is not the case. Will take another look.
I think it's not deterministic, especially if you use a high-enough "-j"
value.
It's better to just add it, since it is in fact a dependency. This
isn't hard... we can approve it locally and then upstreaming it to gcc
should not controversial.
>> it's only used in tracepoint.c. Will remove the include from
>> tracefile.c and mi-main.c and rename it to "tracectf.h"?
Works for me!
Tom
prev parent reply other threads:[~2019-07-26 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 23:57 Weimin Pan
2019-07-24 19:56 ` Tom Tromey
2019-07-24 23:50 ` Wei-min Pan
2019-07-25 12:43 ` Tom Tromey
2019-07-26 0:13 ` Wei-min Pan
2019-07-26 2:09 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875znpk0mx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox