From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113244 invoked by alias); 26 Jul 2019 02:09:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113170 invoked by uid 89); 26 Jul 2019 02:09:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:539 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 02:09:13 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 282CF4B72 for ; Thu, 25 Jul 2019 21:09:12 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qpfUhOQ1PYTGMqpfUhD8hb; Thu, 25 Jul 2019 21:09:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JIELtOyyLSsLefzLM0A3/QUDX+0ncOa8oeyU6MZn+R0=; b=iffnORKMZjkG+r6CIP2y47Za9s BB7oN+ASq9F0qhoVypx67mnlb9AKw+5uR4GblXnys9Sj6Y/XJ8GrkUsNnbEiRqIDefKJS1/N51/bS NzoS4lh94ol7dkrhaYgvBNu9D; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:41810 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hqpfT-001yex-SX; Thu, 25 Jul 2019 21:09:12 -0500 From: Tom Tromey To: Wei-min Pan Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: CTF support References: <1563926228-31569-1-git-send-email-weimin.pan@oracle.com> <87v9vrtde8.fsf@tromey.com> <87o91ithd9.fsf@tromey.com> <389644b2-5fb4-b963-f362-e9a2e34b44ac@oracle.com> Date: Fri, 26 Jul 2019 02:09:00 -0000 In-Reply-To: <389644b2-5fb4-b963-f362-e9a2e34b44ac@oracle.com> (Wei-min Pan's message of "Thu, 25 Jul 2019 17:13:01 -0700") Message-ID: <875znpk0mx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00568.txt.bz2 >> If libctf were not built before gdb, gdb build would have failed >> which is not the case. Will take another look. I think it's not deterministic, especially if you use a high-enough "-j" value. It's better to just add it, since it is in fact a dependency. This isn't hard... we can approve it locally and then upstreaming it to gcc should not controversial. >> it's only used in tracepoint.c. Will remove the include from >> tracefile.c and mi-main.c and rename it to "tracectf.h"? Works for me! Tom