From: Tom Tromey <tom@tromey.com>
To: Dominik Mascherbauer <dominik.mascherbauer@gmail.com>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org,
dominikmascherbauer <dominik.mascherbauer@oracle.com>
Subject: Re: [PATCH 0/3] DWARF type signature lookup fallback.
Date: Thu, 13 Mar 2025 09:37:39 -0600 [thread overview]
Message-ID: <875xkdq6v0.fsf@tromey.com> (raw)
In-Reply-To: <c3eeb0f6-ccfd-4880-8454-049d170e0479@gmail.com> (Dominik Mascherbauer's message of "Thu, 13 Mar 2025 11:42:26 +0100")
>>>>> "Dominik" == Dominik Mascherbauer <dominik.mascherbauer@gmail.com> writes:
Dominik> Thanks for the response. I agree that this series violates rule 2 as you
Dominik> mentioned. I was not aware of those rules at the time of implementing
Dominik> this patch.
Totally understandable, since if they are written down anywhere, it's in
some comment "somewhere".
Dominik> My initial idea was to use type signatures as they should be unique even
Dominik> across multiple objfiles. Based on that I thought it would be possible
Dominik> to use type signatures for finding type units in other not linked
Dominik> objfiles such as objfiles coming from the JIT compilation interface.
FWIW I think your insight here is correct.
Dominik> I tested opaque types for my use-case, and it did work out. So, I guess the
Dominik> best option for me is to adapt the generated debug info for opaque types.
I wonder if integrating type signatures into 'struct type' would be
possible. That is, an opaque type could store its signature. Then
there'd be a new "quick" API method to look up a full type (which gdb
confusingly calls "transparent") by signature.
This might solve your problem without violating the lifetime rules and
without requiring type GC.
thanks,
Tom
prev parent reply other threads:[~2025-03-13 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 14:57 dominikmascherbauer
2025-03-11 14:57 ` [PATCH 1/3] Add new commands for controlling type signature fallback dominikmascherbauer
2025-03-11 17:33 ` Eli Zaretskii
2025-03-12 9:12 ` Dominik Mascherbauer
2025-03-12 14:38 ` Eli Zaretskii
2025-03-12 14:44 ` Dominik Mascherbauer
2025-03-11 14:57 ` [PATCH 2/3] Add type signature fallback and JIT objfile restriction dominikmascherbauer
2025-03-11 14:57 ` [PATCH 3/3] Add testing for type signature fallback dominikmascherbauer
2025-03-12 15:37 ` [PATCH v2 0/3] DWARF type signature lookup fallback dominikmascherbauer
2025-03-12 15:37 ` [PATCH v2 1/3] Add new commands for controlling type signature fallback dominikmascherbauer
2025-03-12 15:43 ` Eli Zaretskii
2025-03-12 15:37 ` [PATCH v2 2/3] Add type signature fallback and JIT objfile restriction dominikmascherbauer
2025-03-12 15:37 ` [PATCH v2 3/3] Add testing for type signature fallback dominikmascherbauer
2025-03-12 16:32 ` [PATCH 0/3] DWARF type signature lookup fallback Tom Tromey
2025-03-13 10:42 ` Dominik Mascherbauer
2025-03-13 15:37 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xkdq6v0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=dominik.mascherbauer@gmail.com \
--cc=dominik.mascherbauer@oracle.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox