Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dominik Mascherbauer <dominik.mascherbauer@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add new commands for controlling type signature fallback.
Date: Wed, 12 Mar 2025 16:38:23 +0200	[thread overview]
Message-ID: <86jz8u5n6o.fsf@gnu.org> (raw)
In-Reply-To: <3237e31f-16f6-4337-8c09-0d26aee35fc9@gmail.com> (message from Dominik Mascherbauer on Wed, 12 Mar 2025 10:12:23 +0100)

> Date: Wed, 12 Mar 2025 10:12:23 +0100
> Cc: gdb-patches@sourceware.org
> From: Dominik Mascherbauer <dominik.mascherbauer@gmail.com>
> 
> Would this be enough, or does it need to be more detailed:

I think it should be enough, but there are typos to fix:

> +  If type signatures in DWARF objfile are unique, enabling this option to look
> +  up type signatures from fallback DWARF objfiles.

This sentence is incomplete, or maybe some words need to be modified.

> +Control the behavior of the type signature look up in DWARF objfiles.  Type
> +Signatures in DWARF uniquely identify a type unit.  A type unit contains debug
> +info for a type and can b referenced by its type signature.  Type signature
                           ^
"be"

Thanks.

  reply	other threads:[~2025-03-12 14:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 14:57 [PATCH 0/3] DWARF type signature lookup fallback dominikmascherbauer
2025-03-11 14:57 ` [PATCH 1/3] Add new commands for controlling type signature fallback dominikmascherbauer
2025-03-11 17:33   ` Eli Zaretskii
2025-03-12  9:12     ` Dominik Mascherbauer
2025-03-12 14:38       ` Eli Zaretskii [this message]
2025-03-12 14:44         ` Dominik Mascherbauer
2025-03-11 14:57 ` [PATCH 2/3] Add type signature fallback and JIT objfile restriction dominikmascherbauer
2025-03-11 14:57 ` [PATCH 3/3] Add testing for type signature fallback dominikmascherbauer
2025-03-12 15:37 ` [PATCH v2 0/3] DWARF type signature lookup fallback dominikmascherbauer
2025-03-12 15:37   ` [PATCH v2 1/3] Add new commands for controlling type signature fallback dominikmascherbauer
2025-03-12 15:43     ` Eli Zaretskii
2025-03-12 15:37   ` [PATCH v2 2/3] Add type signature fallback and JIT objfile restriction dominikmascherbauer
2025-03-12 15:37   ` [PATCH v2 3/3] Add testing for type signature fallback dominikmascherbauer
2025-03-12 16:32 ` [PATCH 0/3] DWARF type signature lookup fallback Tom Tromey
2025-03-13 10:42   ` Dominik Mascherbauer
2025-03-13 15:37     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jz8u5n6o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dominik.mascherbauer@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox