Re: [PATCH v2] gdb/dwarf2: Add symbols for function declarations

[Tom Tromey <tom@tromey.com>]

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

Kevin>   This version 2 commit
Kevin> adds that by making DW_TAG_subprogram declarations "interesting" to
Kevin> the indexer.  The changes which do this are in gdb/dwarf2/abbrev.c
Kevin> and gdb/dwarf2/cooked-indexer.c.

I have some questions about this change.

How many symbols does it add, and what performance impact does it have?
I tend to think the indexer is fast primarily because it skips DIEs, but
IIUC this will have it read many more.

Do these declaration symbols end up in .debug_names and .gdb_index?  I
suspect they should not.  (Particularly for .debug_names which
specifically excludes them in the text of the standard.)

Does "break" on such a symbol result in many more CU expansions?  If so
then I think this is a problem, because a declaration by its nature is
not useful for breakpoints.

What does "print malloc" say with this patch in place?

thanks,
Tom