From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ML4zChAEu2hvkxcAWB0awg (envelope-from ) for ; Fri, 05 Sep 2025 11:38:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CbClMlkd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 146531E087; Fri, 05 Sep 2025 11:38:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 878831E023 for ; Fri, 05 Sep 2025 11:38:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 262B33857B98 for ; Fri, 5 Sep 2025 15:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 262B33857B98 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=CbClMlkd Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id D11C03858D37 for ; Fri, 5 Sep 2025 15:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D11C03858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D11C03858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757086697; cv=none; b=iK24FqCOIhs5RLNcN+TtZCNKZ8bRBxEweNPyWHKBWD70X76Qlr/9SJ5kXxwWodh4mRB0OiCEqky2cAiaPsF9ieMFbJC5WDihR/7rcZ1OjJ/HOMlZF6DehooLTZeK/601alEC6+9e21An1oG6GLgyOsH7XM/84E/b75KbS+5xf3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757086697; c=relaxed/simple; bh=mEe9I/iznIGCjjNuLK1WvXdh+l4rb7iL1yRwaMreN5U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HjSZIzMX8ej4I28EiIj+o6tUski8So8vIS06z+TUasTsXxvCWfCNexTXz6gBSh85qT6Uo/Iyhj43swWqZTTETT2gMCxJ3zL8HUnqCe0Len2Y+BK1OfkVuBncYHkjNyQAhYVGV/bRuur5RHWPTnPwBX0i+MgI8VP4sICnkO2m3c0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D11C03858D37 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id uVzkuMXweaPqLuYVzu48ge; Fri, 05 Sep 2025 15:38:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uYVzuj6QmOIXAuYVzuG3LI; Fri, 05 Sep 2025 15:38:15 +0000 X-Authority-Analysis: v=2.4 cv=bKsWIO+Z c=1 sm=1 tr=0 ts=68bb03e7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=Y1j78K6K0YznFPQbss0A:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Lg5ab+j5HMKTKv+fLlWZDRhJEDpwiEMKnOLj0wlwxvc=; b=CbClMlkdghNQc5aY421nxHmx0m 1sDiQgn6dLXlMM//KMrCVPaUfjKjhW/yAGnObEc5iXxKmRjjM0IXQA8FmIyd5T8SyzcATcIqCLX5r tRt4yZ/8ggIzVAdxh6K+Vm9up; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:58284 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uuYVy-00000003O0n-3Zc2; Fri, 05 Sep 2025 09:38:14 -0600 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/dwarf2: Add symbols for function declarations In-Reply-To: <20250703194719.2254338-1-kevinb@redhat.com> (Kevin Buettner's message of "Thu, 3 Jul 2025 12:45:23 -0700") References: <20250703194719.2254338-1-kevinb@redhat.com> X-Attribution: Tom Date: Fri, 05 Sep 2025 09:38:13 -0600 Message-ID: <875xdwsye2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uuYVy-00000003O0n-3Zc2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:58284 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfG85mVIxtDBA89vc5AkjO54GA3tWMBqc4EuSLhf/auL47XMm8j61vkRF1OHM1EnE8Zr/KXqyEpnsvElIZV+ZtDcuK2VpfBxjvpfTr0/xjxhYheGNdmdE RPIMyUz9OgFbRJHNIdGX2I4rZg651jDYpTsJf9/Oi5z7oqw633He3Gc8ACuL9mJoMsNWwbDtIDU+lHOzwafYURgjrRQOk0kGtpE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Kevin" == Kevin Buettner writes: Kevin> This version 2 commit Kevin> adds that by making DW_TAG_subprogram declarations "interesting" to Kevin> the indexer. The changes which do this are in gdb/dwarf2/abbrev.c Kevin> and gdb/dwarf2/cooked-indexer.c. I have some questions about this change. How many symbols does it add, and what performance impact does it have? I tend to think the indexer is fast primarily because it skips DIEs, but IIUC this will have it read many more. Do these declaration symbols end up in .debug_names and .gdb_index? I suspect they should not. (Particularly for .debug_names which specifically excludes them in the text of the standard.) Does "break" on such a symbol result in many more CU expansions? If so then I think this is a problem, because a declaration by its nature is not useful for breakpoints. What does "print malloc" say with this patch in place? thanks, Tom