Re: [PATCH] Allow dynamic DW_AT_bit_stride on DW_TAG_array_type

[Tom Tromey <tromey@adacore.com>]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> I think this is relatively straightforward, and aside from a few
Keith> minor observations, LGTM.

Thanks.

Keith> I see the above code is duplicated below -- is it worth the bother to
Keith> separate into a function? Not an action item. Just a question.

I think the two functions can probably be merged.
I'll take a look at that separately.

>> /* If the stride is seen and used, byte_stride_prop will be
>> non-NULL.  In this case stride_storage will be used to store the
>> data locally.  */

Keith> I think the above comment should now refer to `stride_prop' instead of
Keith> `byte_stride_prop'.

Yeah, fixed.

>> +   IS_BYTE_STRIDE is true, then this is a byte stride; when false this
>> +   is a bit stride.  This stride property is added to the resulting
>> +   array type as a DYN_PROP_BYTE_STRIDE or a DYN_PROP_BIT_SIZE, as

Keith> Should this refer to DYN_PROP_BIT_STRIDE?

Yes, thank you.

I'm going to check this in now.

Tom