From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 68bgMB3h02n4eAoAWB0awg (envelope-from ) for ; Mon, 06 Apr 2026 12:36:45 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=QhPxgeIu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B85951E04F; Mon, 06 Apr 2026 12:36:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9CFA21E04F for ; Mon, 06 Apr 2026 12:36:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BFB944BA2E24 for ; Mon, 6 Apr 2026 16:36:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFB944BA2E24 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=QhPxgeIu Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 71E854BA2E1B for ; Mon, 6 Apr 2026 16:36:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71E854BA2E1B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 71E854BA2E1B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775493373; cv=none; b=PaF8MVMloGnscsoAhb+5Wao2tepIbZqNXllffvRhdWiV3baLImr4eELSTjEtdJ+XJEL5k6z6gkRhhVfG3N+Av5LEdZpZqLw1xwK0jKv8nnhQ3PB9ZTuRTHMqH/hw1JcNcNKhJ7QSuTUCGTXA2Dk21dWtG21AIDNUcSihYbrrUfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775493373; c=relaxed/simple; bh=I1/2AQOumWcq80Hgwnz+4YOlrrT/s8SwJkEMA3eHtvk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xUrjl0l9MYZ5FzP003QvJ+uyhixL9jknSfvSdXxXz+yfPWdhOsUaSckuiZlpquwyMgv+4iyQ5w9b/VFJScoeqeBGyvNlGhd8gjeYJjcvlmFziXXJA+k8wuZG3QyTdU0NJz98TVGvujX+EBj9OHBlc7rJscPWGTA4p4Gl+tJRhHg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71E854BA2E1B Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-7d9b21d1461so4208254a34.1 for ; Mon, 06 Apr 2026 09:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1775493372; x=1776098172; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fRmdoJVGWcd0xdd0uLHkeOH1SKm0I8kKOpxgN3GvMGA=; b=QhPxgeIuON8n+7U9iJvu6eBUZJUH4mOxLGHWEY9cQKBYg9m7FjyDMEUEQ2ANy6hYfq fTV6STuZxFS+A6Ntv/Yjk8dTR740HYWHTQl7BHnp5EW0AhmzzSx20ttb6W8W1NeVOLtq aFMWLLXLvMBIAB7C76/eBtcxnLA/+fN3hRz+XS6TgpBmV++wNgLp31lyA98qYguZj+bv OpGjURFibdNeKKwYb6s4Xg6FUkrgzwS3KpzEMqBHWt88mDdKIxQZK4jHawcT40H3EW69 0dIl+YHHd2UAJZuTobhYQtkFhSXEzS4r5qBEJ1uySalW5CoofdsnKXh8rLSAsrkZomLg G1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775493372; x=1776098172; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fRmdoJVGWcd0xdd0uLHkeOH1SKm0I8kKOpxgN3GvMGA=; b=f8a7uO+nVIZtBiG+cuCv+dt2qm52UM92cTr4nSGmS0LuPNdYezogMD17XG8M+tHj3q Z7QXiuteoexViB3Rw7nLkLCTNCRqM4WlKiZ8fryQem9PKbdPO3aa8hihQLD27Ge/85+N /xIAOEjGX3zNY2rQVdkPWUCzorbAedvWFpTOfI461lwIquQ4acklqZqsYlkk6nEnsEEN yyUPN7dD5oVtqh8kVvub6BMzPsmc3OfMz7RLBqH1I6aYShR9Sxz27jT1fm8PMzAO/ebV j4KNbPFvSPHZp4EyJ05MdUwj1W5Nxlj8bw8kptm2f6kZdWYb0wc4YtVop50tPjskijk3 VgkQ== X-Forwarded-Encrypted: i=1; AJvYcCW0GTW/T1ICvBlzFRlzXEqWGexD2uW5a0yrH+EJWwqjWEx2yg/DdBCMLdaZZF8j6lU59Pp0yW1byDy8VQ==@sourceware.org X-Gm-Message-State: AOJu0YyH8jRQBRjbcfyj+lzJwRl6TANeZsgej7MpYMWUkal7QHVjHBoW eVcV55f200Wx/Y+NloDd2Q/m6YpNISgSheA4yr8nMiRjNehcbbCUMp1LkarUIH7+UuEPD2gXqwK 07r8= X-Gm-Gg: AeBDiese+xvRXYQnQP944ZS3S2l5UW0Sl+KzHRKLEzuS0MOwWpQWoOkAQRKOapdKS+r E7ACHoSjaTuEdluu7rXdLJEqy08QfdbVqZi++Ku7g6zsHWAvm6ZYoQXv2sRdGivxNqFGzTpkloG g4r634BQKCrZl+aq9Kosiqg4Lc+yxFArJzz+vutAnvged7eHdvkjEZzaHPX+tur80g51Ge1cTQr rdAOznCW9mVuQCGdxNXTViaat7VwjAO3TGENzGVkgFXFKCtEHnrfd4LgYjm52MEiN3ZL66Bgcad 0DGmwLYkPz+oW84EuB5fNpqj72h00NdTsAnaotV1jMJbBmCNiVrZr8IR8qVGgMPcAhGRJAo7unI cZCMxY+i+0Tm7rqeHNrASSVuiGWVaAfnhnr/BUb5s9Xyr0dn2FtPytEfD8s1tNlqt6b+BxKk+KO 0QBgy3QAn8YELqx6HjK+XvHZ4cerdySx5KDAmKxPV+NGo= X-Received: by 2002:a05:6830:6aa1:b0:7d7:e3d7:e200 with SMTP id 46e09a7af769-7dbb7a24dabmr7129685a34.6.1775493372653; Mon, 06 Apr 2026 09:36:12 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dbed6c3512sm971660a34.4.2026.04.06.09.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 09:36:12 -0700 (PDT) From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Allow dynamic DW_AT_bit_stride on DW_TAG_array_type In-Reply-To: <192dd160-d97c-4ba3-8917-a6e1bbaba6b0@redhat.com> (Keith Seitz's message of "Fri, 3 Apr 2026 12:56:21 -0700") References: <20260320125356.1230088-1-tromey@adacore.com> <192dd160-d97c-4ba3-8917-a6e1bbaba6b0@redhat.com> X-Attribution: Tom Date: Mon, 06 Apr 2026 10:36:11 -0600 Message-ID: <875x64yrk4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Keith" == Keith Seitz writes: Keith> I think this is relatively straightforward, and aside from a few Keith> minor observations, LGTM. Thanks. Keith> I see the above code is duplicated below -- is it worth the bother to Keith> separate into a function? Not an action item. Just a question. I think the two functions can probably be merged. I'll take a look at that separately. >> /* If the stride is seen and used, byte_stride_prop will be >> non-NULL. In this case stride_storage will be used to store the >> data locally. */ Keith> I think the above comment should now refer to `stride_prop' instead of Keith> `byte_stride_prop'. Yeah, fixed. >> + IS_BYTE_STRIDE is true, then this is a byte stride; when false this >> + is a bit stride. This stride property is added to the resulting >> + array type as a DYN_PROP_BYTE_STRIDE or a DYN_PROP_BIT_SIZE, as Keith> Should this refer to DYN_PROP_BIT_STRIDE? Yes, thank you. I'm going to check this in now. Tom