From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)
Date: Thu, 13 Sep 2012 20:43:00 -0000 [thread overview]
Message-ID: <874nn13b8k.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120912180235.GA13250@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 12 Sep 2012 20:02:35 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I am not completely sure the patch in skip_inlined_frames is
Jan> appropriate for all the callers of skip_inlined_frames but it seems
Jan> so to me, frame_id of TAILCALL_FRAME is artifical the same way like
Jan> INLINE_FRAME is.
This argument is persuasive, but the patch still makes me a bit nervous,
just because the concrete details at each call point may matter.
It seems some comments need updating, e.g., inline_depth is overloaded
but the comment doesn't indicate this.
Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu.
Jan> I would think this should be even for 7.5.
Me too. I'm inclined to say it should go in.
Tom
next prev parent reply other threads:[~2012-09-13 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 18:03 Jan Kratochvil
2012-09-13 20:43 ` Tom Tromey [this message]
2012-09-13 22:37 ` Joel Brobecker
2012-09-14 8:08 ` Jan Kratochvil
2012-09-14 14:43 ` Tom Tromey
2012-09-16 21:44 ` Joel Brobecker
2012-09-17 7:20 ` [commit+7.5] " Jan Kratochvil
2012-09-14 8:06 ` [patch] Code cleanup - inline -> artificial depth [Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)] Jan Kratochvil
2012-09-14 15:46 ` Tom Tromey
2012-09-17 7:04 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nn13b8k.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox