From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)
Date: Thu, 13 Sep 2012 22:37:00 -0000 [thread overview]
Message-ID: <20120913223722.GA18571@adacore.com> (raw)
In-Reply-To: <874nn13b8k.fsf@fleche.redhat.com>
> Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu.
> Jan> I would think this should be even for 7.5.
>
> Me too. I'm inclined to say it should go in.
I have to say, the patch makes me a little nervous. But I agree
that an internal-error is horrible. That's 2 GMs in favor of putting
it in 7.5, so it's OK with me. Perhaps you might want to hold off
on the branch, and observe the patch on the HEAD before porting it
to the branch? Just a suggestion, I don't mind either way.
--
Joel
next prev parent reply other threads:[~2012-09-13 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 18:03 Jan Kratochvil
2012-09-13 20:43 ` Tom Tromey
2012-09-13 22:37 ` Joel Brobecker [this message]
2012-09-14 8:08 ` Jan Kratochvil
2012-09-14 14:43 ` Tom Tromey
2012-09-16 21:44 ` Joel Brobecker
2012-09-17 7:20 ` [commit+7.5] " Jan Kratochvil
2012-09-14 8:06 ` [patch] Code cleanup - inline -> artificial depth [Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)] Jan Kratochvil
2012-09-14 15:46 ` Tom Tromey
2012-09-17 7:04 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913223722.GA18571@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox