From: Tom Tromey <tromey@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Expand LEN parameter of value_*string functions
Date: Wed, 26 Sep 2012 17:37:00 -0000 [thread overview]
Message-ID: <874nmkznvq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120925203940.591674f1@spoyarek> (Siddhesh Poyarekar's message of "Tue, 25 Sep 2012 20:39:40 +0530")
>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:
Siddhesh> The value_string and value_cstring functions take string
Siddhesh> lengths as parameters and that ought to be at least ssize_t.
Siddhesh> * gdbtypes.c (lookup_array_range_type): Expand parameters
Siddhesh> LOW_BOUND and HIGH_BOUND to LONGEST.
Siddhesh> (lookup_string_range_type): Likewise.
Siddhesh> * gdbtypes.h (lookup_array_range_type): Likewise.
Siddhesh> (lookup_string_range_type): Likewise.
Siddhesh> * valops.c (value_cstring): Expand parameter LEN to ssize_t.
Siddhesh> Expand HIGHBOUND to ssize_t.
Siddhesh> (value_string): Likewise.
Siddhesh> * value.h (value_cstring): Expand parameter LEN to ssize_t.
Siddhesh> (value_string): Likewise.
Ok. Thanks.
Tom
prev parent reply other threads:[~2012-09-26 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 15:54 Siddhesh Poyarekar
2012-09-26 17:37 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nmkznvq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox