From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28857 invoked by alias); 26 Sep 2012 17:37:53 -0000 Received: (qmail 28849 invoked by uid 22791); 26 Sep 2012 17:37:52 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 17:37:31 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QHbUlt002629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 13:37:30 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8QHbTbm016888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 26 Sep 2012 13:37:29 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Expand LEN parameter of value_*string functions References: <20120925203940.591674f1@spoyarek> Date: Wed, 26 Sep 2012 17:37:00 -0000 In-Reply-To: <20120925203940.591674f1@spoyarek> (Siddhesh Poyarekar's message of "Tue, 25 Sep 2012 20:39:40 +0530") Message-ID: <874nmkznvq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00600.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> The value_string and value_cstring functions take string Siddhesh> lengths as parameters and that ought to be at least ssize_t. Siddhesh> * gdbtypes.c (lookup_array_range_type): Expand parameters Siddhesh> LOW_BOUND and HIGH_BOUND to LONGEST. Siddhesh> (lookup_string_range_type): Likewise. Siddhesh> * gdbtypes.h (lookup_array_range_type): Likewise. Siddhesh> (lookup_string_range_type): Likewise. Siddhesh> * valops.c (value_cstring): Expand parameter LEN to ssize_t. Siddhesh> Expand HIGHBOUND to ssize_t. Siddhesh> (value_string): Likewise. Siddhesh> * value.h (value_cstring): Expand parameter LEN to ssize_t. Siddhesh> (value_string): Likewise. Ok. Thanks. Tom