From: Tom Tromey <tromey@redhat.com>
To: Stephane Carrez <stephane.carrez@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH]: Fix gdb's prompt for continue in TUI SingleKey mode
Date: Mon, 12 Nov 2012 15:44:00 -0000 [thread overview]
Message-ID: <874nkuddwl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAJJuuYo440ttti=aWKXz9LkGvas6Ub2TWn14v6RBRBnVS+1cuw@mail.gmail.com> (Stephane Carrez's message of "Sat, 10 Nov 2012 14:24:51 +0100")
>>>>> "Stephane" == Stephane Carrez <stephane.carrez@gmail.com> writes:
Stephane> Basically when we execute a gdb command, we must be in
Stephane> TUI_ONE_COMMAND_MODE (or TUI_COMMAND_MODE). We must restore
Stephane> the TUI_SINGLE_KEY_MODE only if we are not called from
Stephane> prompt_for_continue (I've used the check on 'immediate_quit'
Stephane> for that).
I don't know this code at all, but I think checking immediate_quit here
is weird. Partly this is because I think most uses of immediate_quit in
gdb are incorrect, and I'd like to try to phase them out -- but having
the TUI depend on it makes this harder. Is there some other way to do
it?
Tom
next prev parent reply other threads:[~2012-11-12 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 13:25 Stephane Carrez
2012-11-12 15:44 ` Tom Tromey [this message]
2012-11-13 7:36 ` Stephane Carrez
2012-11-13 16:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nkuddwl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stephane.carrez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox