From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95843-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21766 invoked by alias); 12 Nov 2012 15:44:38 -0000
Received: (qmail 21754 invoked by uid 22791); 12 Nov 2012 15:44:37 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 15:44:29 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qACFiSjW028859	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 12 Nov 2012 10:44:28 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qACFiQfJ018086	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 12 Nov 2012 10:44:27 -0500
From: Tom Tromey <tromey@redhat.com>
To: Stephane Carrez <stephane.carrez@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH]: Fix gdb's prompt for continue in TUI SingleKey mode
References: <CAJJuuYo440ttti=aWKXz9LkGvas6Ub2TWn14v6RBRBnVS+1cuw@mail.gmail.com>
Date: Mon, 12 Nov 2012 15:44:00 -0000
In-Reply-To: <CAJJuuYo440ttti=aWKXz9LkGvas6Ub2TWn14v6RBRBnVS+1cuw@mail.gmail.com>	(Stephane Carrez's message of "Sat, 10 Nov 2012 14:24:51 +0100")
Message-ID: <874nkuddwl.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00281.txt.bz2

>>>>> "Stephane" == Stephane Carrez <stephane.carrez@gmail.com> writes:

Stephane> Basically when we execute a gdb command, we must be in
Stephane> TUI_ONE_COMMAND_MODE (or TUI_COMMAND_MODE).  We must restore
Stephane> the TUI_SINGLE_KEY_MODE only if we are not called from
Stephane> prompt_for_continue (I've used the check on 'immediate_quit'
Stephane> for that).

I don't know this code at all, but I think checking immediate_quit here
is weird.  Partly this is because I think most uses of immediate_quit in
gdb are incorrect, and I'd like to try to phase them out -- but having
the TUI depend on it makes this harder.  Is there some other way to do
it?

Tom