Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: add facility to add values into the history
Date: Mon, 23 Aug 2021 14:32:03 -0600	[thread overview]
Message-ID: <874kbfaon0.fsf@tromey.com> (raw)
In-Reply-To: <20210820084819.1503468-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 20 Aug 2021 09:48:19 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> The guile API has (history-append! <value>) to add values into GDB's
Andrew> history list.  There is currently no equivalent in the Python API.

Andrew> This commit adds gdb.history_add(<value>) to the Python API, this
Andrew> function adds <value> into the history list, and returns the index of
Andrew> the new item in the history list.

Andrew> The <value> can be a gdb.Value object, or anything that can be passed
Andrew> to the constructor of gdb.Value.

This seems fine to me, though I think that normally the gdb Python API
uses "verb_object" instead of "object_verb", so I'd expect "add_history"
as the name instead.

However I don't feel all that strongly about it.
Thanks for doing this.

Tom

  reply	other threads:[~2021-08-23 20:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  8:48 Andrew Burgess
2021-08-23 20:32 ` Tom Tromey [this message]
2021-08-25 17:27   ` [PATCHv2] " Andrew Burgess
2021-08-25 18:01     ` Eli Zaretskii via Gdb-patches
2021-08-26  9:20       ` Andrew Burgess
2021-08-26  9:40         ` Eli Zaretskii via Gdb-patches
2021-09-07  9:56           ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kbfaon0.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox