From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UKMeAdwFJGHGOwAAWB0awg (envelope-from ) for ; Mon, 23 Aug 2021 16:32:28 -0400 Received: by simark.ca (Postfix, from userid 112) id DC1791EE18; Mon, 23 Aug 2021 16:32:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 209611E813 for ; Mon, 23 Aug 2021 16:32:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85AD73857406 for ; Mon, 23 Aug 2021 20:32:26 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.231]) by sourceware.org (Postfix) with ESMTPS id ADE5D3858C2C for ; Mon, 23 Aug 2021 20:32:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADE5D3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 19B0B2B5940 for ; Mon, 23 Aug 2021 15:32:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IGc0mGl3BBvjyIGc0mrGQt; Mon, 23 Aug 2021 15:32:04 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hyfKy9OTuEQFZ4GZ7Czd5f+Xj9fEiPlI4xN0pK3/Fto=; b=JXGtQTrE64h1oYLnPGa6CszNFd rgS4TMNWmtGMfYawIvgMIMlsRm0bCwGDvak+MhZl0V3vVsMzvN2XxJXrb/U0lvNcYJ6xLJA7+pU3j Vg0Wr3LTHm9q9opslHar1kIly; Received: from 97-122-86-84.hlrn.qwest.net ([97.122.86.84]:36702 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mIGbz-000QZj-PW; Mon, 23 Aug 2021 14:32:03 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH] gdb/python: add facility to add values into the history References: <20210820084819.1503468-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Mon, 23 Aug 2021 14:32:03 -0600 In-Reply-To: <20210820084819.1503468-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Fri, 20 Aug 2021 09:48:19 +0100") Message-ID: <874kbfaon0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.84 X-Source-L: No X-Exim-ID: 1mIGbz-000QZj-PW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-84.hlrn.qwest.net (murgatroyd) [97.122.86.84]:36702 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> The guile API has (history-append! ) to add values into GDB's Andrew> history list. There is currently no equivalent in the Python API. Andrew> This commit adds gdb.history_add() to the Python API, this Andrew> function adds into the history list, and returns the index of Andrew> the new item in the history list. Andrew> The can be a gdb.Value object, or anything that can be passed Andrew> to the constructor of gdb.Value. This seems fine to me, though I think that normally the gdb Python API uses "verb_object" instead of "object_verb", so I'd expect "add_history" as the name instead. However I don't feel all that strongly about it. Thanks for doing this. Tom