From: Tom Tromey <tom@tromey.com>
To: Patrick Monnerat <patrick@monnerat.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Support MinGW & 64-bit libraries/paths in Tcl autoconf scripts
Date: Fri, 03 Apr 2026 13:36:36 -0600 [thread overview]
Message-ID: <874ilr4z0b.fsf@tromey.com> (raw)
In-Reply-To: <20260331151659.464416-2-patrick@monnerat.net> (Patrick Monnerat's message of "Tue, 31 Mar 2026 17:16:59 +0200")
>>>>> "Patrick" == Patrick Monnerat <patrick@monnerat.net> writes:
Patrick> Updated patch version fixes an m4 escape problem, normalizes spacing in
Patrick> config/tcl.m4 and also provides gdb/configure updated accordingly.
Since this is Insight-specific I tend to think it's fine to do as you
like.
Approved-By: Tom Tromey <tom@tromey.com>
Patrick> Debian implements directories /usr/lib32 and /usr/lib64, but installs
Patrick> tclConfig.sh and tkConfig.sh in /usr/lib. Therefore always search in
Patrick> /usr/lib when the others fail.
Patrick> + # Check where 32-bit vs 64-bit libraries are stored
Patrick> + lib32="/usr/lib"
Patrick> + lib64="/usr/lib"
Patrick> + if test -d /usr/lib32 ; then
Patrick> + lib32="/usr/lib32"
Patrick> + fi
Patrick> + if test -d /usr/lib64 ; then
Patrick> + lib64="/usr/lib64"
Patrick> + fi
Hard coding like this is a bit weird for configure IMO.
I wonder if this could use pkg-config instead.
I still think it's fine in this case though.
thanks,
Tom
next prev parent reply other threads:[~2026-04-03 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:16 Patrick Monnerat
2026-04-03 19:36 ` Tom Tromey [this message]
2026-04-03 22:42 ` Patrick Monnerat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ilr4z0b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@monnerat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox