From: Patrick Monnerat <patrick@monnerat.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Support MinGW & 64-bit libraries/paths in Tcl autoconf scripts
Date: Sat, 4 Apr 2026 00:42:56 +0200 [thread overview]
Message-ID: <6d4a9b53-3942-40a1-884c-d9ad4e393a1a@monnerat.net> (raw)
In-Reply-To: <874ilr4z0b.fsf@tromey.com>
On 4/3/26 9:36 PM, Tom Tromey wrote:
>>>>>> "Patrick" == Patrick Monnerat <patrick@monnerat.net> writes:
> Patrick> Updated patch version fixes an m4 escape problem, normalizes spacing in
> Patrick> config/tcl.m4 and also provides gdb/configure updated accordingly.
>
> Since this is Insight-specific I tend to think it's fine to do as you
> like.
>
> Approved-By: Tom Tromey <tom@tromey.com>
Many thanks for approval, Tom.
In fact, I already commited it, thinking nobdy would react:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=095037e241aaeb8baa41842a75d8e5df73d2e51d
>
> Patrick> Debian implements directories /usr/lib32 and /usr/lib64, but installs
> Patrick> tclConfig.sh and tkConfig.sh in /usr/lib. Therefore always search in
> Patrick> /usr/lib when the others fail.
>
> Patrick> + # Check where 32-bit vs 64-bit libraries are stored
> Patrick> + lib32="/usr/lib"
> Patrick> + lib64="/usr/lib"
> Patrick> + if test -d /usr/lib32 ; then
> Patrick> + lib32="/usr/lib32"
> Patrick> + fi
> Patrick> + if test -d /usr/lib64 ; then
> Patrick> + lib64="/usr/lib64"
> Patrick> + fi
>
> Hard coding like this is a bit weird for configure IMO.
> I wonder if this could use pkg-config instead.
Agreed. But no, because the goal is to locate the file tclConfig.sh that
is not supported by pkg-config and is stored in different locations
among various distros.
In addition, upstream Tcl still uses this method nowadays:
https://core.tcl-lang.org/tcl/file?name=unix/tcl.m4&ci=tip and
https://core.tcl-lang.org/tcl/file?name=win/tcl.m4&ci=tip.
I prefer to use the current updated version because 1) tcl.m4 is not
installed by the tcl(-devel) package and 2) I'm sure it still works with
old tcl versions.
gcc scm was the last file source (2015) for binutils-gdb but although
still present there, it has been abandoned and forgotten, IMO.
prev parent reply other threads:[~2026-04-03 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:16 Patrick Monnerat
2026-04-03 19:36 ` Tom Tromey
2026-04-03 22:42 ` Patrick Monnerat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4a9b53-3942-40a1-884c-d9ad4e393a1a@monnerat.net \
--to=patrick@monnerat.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox