Re: [PATCH] Implement windows_nat_target::stop

[Tom Tromey <tom@tromey.com>]

>>>>> "Patrick" == Patrick Monnerat <patrick@monnerat.net> writes:

Patrick> Insight makes a difference between hitting Ctrl-C (that triggers
Patrick> target::pass_ctrlc) and clicking the GUI stop button, triggering
Patrick> target::stop).

I wonder why.

Also I see Insight calls target_stop and not target_stop_and_wait, which
seems a bit weird.

Patrick> As windows_nat did not implement the stop method, the GUI stop button
Patrick> was inoperant on Windows.

Patrick> +void
Patrick> +windows_nat_target::stop (ptid_t ptid)
Patrick> +{
Patrick> +  interrupt ();
Patrick> +}

I don't really know the contract here but is interrupt guaranteed to
stop PTID?  Like is the relevant inferior always selected?  How does
this interact with non-stop?

Right now it's probably somewhat moot but there's ongoing work for
non-stop and multi-inferior on Windows.

Tom