From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lfPCJ7th3mlOHhcAWB0awg (envelope-from ) for ; Tue, 14 Apr 2026 11:48:11 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sclj5cSP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 90DA31E0C3; Tue, 14 Apr 2026 11:48:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D63A21E04F for ; Tue, 14 Apr 2026 11:48:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 45B4E4BA2E32 for ; Tue, 14 Apr 2026 15:48:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45B4E4BA2E32 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=sclj5cSP Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id D90024BA2E09 for ; Tue, 14 Apr 2026 15:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D90024BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D90024BA2E09 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776181664; cv=none; b=mnrfbCcoOP3OJmU6TEKyVOUppV4wjezZxPhFR6SnPsorxKtEwfQnIk2oQlFGuJNzez4lcqR6UMLOyrbqfpzzt/auOe0jnlpJB10n1D4vTk3k5jnpbx/31s3fVwdmYUG43xFN245zsti5ABl0ndRVE2ge2uPbIQ1OsNoaFTIyyoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776181664; c=relaxed/simple; bh=Ch1FCvJv7sUs0zfp5KMYknpA7uhcIgj9HWYfyxqxx+0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WHGt1bxTrwnL6h9FTJ55jtGNFJ+zlRhy9/B+isBMbygJJM9EsOHcQDPsubLkd0Y4K19ckAR82vX5Hv7Og86bkPTlSjDSgXZegJHdtEd44gbwV5GmoaoBNuKf3SNzYiWuOsGKajY7SbURsW1scz5E8Qct3AnPvLCxP40kZuCVkC0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D90024BA2E09 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id CeqWwjB2TObRfCfzMwWQY2; Tue, 14 Apr 2026 15:47:44 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CfzKwO0JqQLXzCfzLwgckI; Tue, 14 Apr 2026 15:47:43 +0000 X-Authority-Analysis: v=2.4 cv=DodW+H/+ c=1 sm=1 tr=0 ts=69de61a0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=IhchGgkyAAAA:8 a=upVWZBip8LH3v_F5HdcA:9 a=K_lBPDZq2WP7QSumrQz8:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0ja1Orgg8uZb6GjfsCq+QJgbJiHyB89hQKgeBrlxELw=; b=sclj5cSPzG4RqPGt9lR5Ks7qiV xlO2jzEcPQXcWHo7HSoD2TyK0fT9Bj/s+9pkrP/qwd0VUdJGrs9+Nl0IWf5ukUfRP4dGCvCsB38pH ngL18TxRiGDBo0Evx1vOceTR4; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:45596 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCfzK-00000003muK-1VN6; Tue, 14 Apr 2026 09:47:42 -0600 From: Tom Tromey To: Patrick Monnerat Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Implement windows_nat_target::stop In-Reply-To: <20260411143242.143320-2-patrick@monnerat.net> (Patrick Monnerat's message of "Sat, 11 Apr 2026 16:32:43 +0200") References: <20260411143242.143320-2-patrick@monnerat.net> X-Attribution: Tom Date: Tue, 14 Apr 2026 09:47:41 -0600 Message-ID: <874ildwnky.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wCfzK-00000003muK-1VN6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:45596 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHMHnh8FlN+eqUiywgz1n1GGreZKl7FOC89T2sXFB86J/DFuqbJbI2+SWpM4bi2ZQx08GK+Vspdx9G9vPiqMz7qb8iwWKsDcK97UQ/z1wC2GUw0XiZGU P21JBBhE6XKujvf8YBRpAOwJtHF598Spn8pFbCssxL6plL83sXppri4S2voGnDUyUMNGoK0WWil57ycnTfPToT5gPpsvlxPaSxo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Patrick" == Patrick Monnerat writes: Patrick> Insight makes a difference between hitting Ctrl-C (that triggers Patrick> target::pass_ctrlc) and clicking the GUI stop button, triggering Patrick> target::stop). I wonder why. Also I see Insight calls target_stop and not target_stop_and_wait, which seems a bit weird. Patrick> As windows_nat did not implement the stop method, the GUI stop button Patrick> was inoperant on Windows. Patrick> +void Patrick> +windows_nat_target::stop (ptid_t ptid) Patrick> +{ Patrick> + interrupt (); Patrick> +} I don't really know the contract here but is interrupt guaranteed to stop PTID? Like is the relevant inferior always selected? How does this interact with non-stop? Right now it's probably somewhat moot but there's ongoing work for non-stop and multi-inferior on Windows. Tom