From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] [gdb/build, clang] Fix ignored aligned attribute
Date: Fri, 12 Jun 2026 07:24:30 -0600 [thread overview]
Message-ID: <874ij7evsh.fsf@tromey.com> (raw)
In-Reply-To: <20260612104134.4147876-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 12 Jun 2026 12:41:34 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> PR build/34279 reports a build failure with clang.
Tom> This is a regression since commit 6c85ef111b0 ("[gdb] Use using instead of
Tom> typedef"), which did:
Tom> ...
Tom> -typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t;
Tom> +using compat_x32_clock_t = long __attribute__ ((__aligned__ (4)));
Tom> ...
Tom> The problem is that clang ignores the attribute.
Very surprising.
Tom> /* For x32, clock_t in _sigchld is 64bit aligned at 4 bytes. */
Tom> -using compat_x32_clock_t = long __attribute__ ((__aligned__ (4)));
Tom> +typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t;
I think if we need this to remain a typedef, a comment explaining the
reason would be good.
Tom
next prev parent reply other threads:[~2026-06-12 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 10:41 Tom de Vries
2026-06-12 13:24 ` Tom Tromey [this message]
2026-06-16 7:26 ` Tom de Vries
2026-06-12 13:26 ` Pedro Alves
2026-06-16 6:27 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ij7evsh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox