Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/build, clang] Fix ignored aligned attribute
Date: Fri, 12 Jun 2026 12:41:34 +0200	[thread overview]
Message-ID: <20260612104134.4147876-1-tdevries@suse.de> (raw)

PR build/34279 reports a build failure with clang.

This is a regression since commit 6c85ef111b0 ("[gdb] Use using instead of
typedef"), which did:
...
-typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t;
+using compat_x32_clock_t = long __attribute__ ((__aligned__ (4)));
...

The problem is that clang ignores the attribute.

Fix this by reverting this part of the commit.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34279
---
 gdb/nat/amd64-linux-siginfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/nat/amd64-linux-siginfo.c b/gdb/nat/amd64-linux-siginfo.c
index 8f1e4acc47e..99faccabf37 100644
--- a/gdb/nat/amd64-linux-siginfo.c
+++ b/gdb/nat/amd64-linux-siginfo.c
@@ -203,7 +203,7 @@ struct compat_siginfo_t
 };
 
 /* For x32, clock_t in _sigchld is 64bit aligned at 4 bytes.  */
-using compat_x32_clock_t = long __attribute__ ((__aligned__ (4)));
+typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t;
 
 struct __attribute__ ((__aligned__ (8))) compat_x32_siginfo_t
 {

base-commit: 4cdc9a9d93571737476034869dd8caaecb5ca35d
-- 
2.51.0


             reply	other threads:[~2026-06-12 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 10:41 Tom de Vries [this message]
2026-06-12 13:24 ` Tom Tromey
2026-06-16  7:26   ` Tom de Vries
2026-06-12 13:26 ` Pedro Alves
2026-06-16  6:27   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260612104134.4147876-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox