From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>,
asmwarrior@gmail.com
Subject: Re: [RFA] Fix number lexing, again
Date: Mon, 30 Jul 2012 17:13:00 -0000 [thread overview]
Message-ID: <87394941ff.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5016B87B.8070004@redhat.com> (Keith Seitz's message of "Mon, 30 Jul 2012 09:38:19 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> While the list of growing terminations for the string is getting
Keith> tediously long, I don't think inverting the test would be any
Keith> shorter/clearer. WDYT?
I agree.
The patch is ok; so is the test suite patch.
Keith> PS. Also recommending this for 7.5.
Yes please.
Tom
next prev parent reply other threads:[~2012-07-30 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:38 Keith Seitz
2012-07-30 16:42 ` Keith Seitz
2012-07-30 17:13 ` Tom Tromey [this message]
2012-07-30 18:06 ` Keith Seitz
2012-07-30 22:45 ` asmwarrior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87394941ff.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox