From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32083 invoked by alias); 30 Jul 2012 17:13:58 -0000 Received: (qmail 32066 invoked by uid 22791); 30 Jul 2012 17:13:56 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 17:13:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6UHDf0m004402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jul 2012 13:13:41 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6UHDeSB010997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 30 Jul 2012 13:13:40 -0400 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" , asmwarrior@gmail.com Subject: Re: [RFA] Fix number lexing, again References: <5016B87B.8070004@redhat.com> Date: Mon, 30 Jul 2012 17:13:00 -0000 In-Reply-To: <5016B87B.8070004@redhat.com> (Keith Seitz's message of "Mon, 30 Jul 2012 09:38:19 -0700") Message-ID: <87394941ff.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00767.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> While the list of growing terminations for the string is getting Keith> tediously long, I don't think inverting the test would be any Keith> shorter/clearer. WDYT? I agree. The patch is ok; so is the test suite patch. Keith> PS. Also recommending this for 7.5. Yes please. Tom