Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC] PR 15075 dprintf interferes with "next"
Date: Thu, 21 Feb 2013 16:36:00 -0000	[thread overview]
Message-ID: <8738wpd3qe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1361192891-29341-1-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Mon, 18 Feb 2013 21:08:11 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> The printf stuff is implemented as command, it is convenient to move
Yao> them to the target side.  I tried to change the bpstat saying that
Yao> "don't stop", but the command can't be executed.  We have to keep
Yao> bpstat saying that "stop" for dprintf.  I also thought about Tom's
Yao> suggestion about Python "Breakpoint.stop" API, but "Breakpoint.stop"
Yao> acts as condition instead of command, so I don't go that way.

Pedro pointed out that 'stop' runs too early -- it makes "cond" not work
on a dprintf.  (BTW if there is no test for this, there should be... )

But, why not just do the work just after the condition is evaluated?
For example, it could be done with special handling in
bpstat_check_breakpoint_conditions, or by introducing a new
check_condition breakpoint_ops method, with the dprintf method calling
the super method before proceeding to "printf" and then returning 0.

I tend to think that the "commands" approach is just not a good one.

Tom


  parent reply	other threads:[~2013-02-21 16:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 13:09 Yao Qi
2013-02-18 21:36 ` Joel Brobecker
2013-02-21 16:36 ` Tom Tromey [this message]
2013-04-24  1:24   ` Hui Zhu
2013-04-24  6:06     ` Keith Seitz
2013-04-24 13:30       ` Hui Zhu
2013-04-24 14:03         ` Yao Qi
2013-04-24 14:09           ` Hui Zhu
2013-05-16  7:29             ` Hui Zhu
2013-05-17 21:01               ` Pedro Alves
2013-05-22 10:22                 ` Hui Zhu
2013-05-22 12:46                   ` Pedro Alves
2013-05-28  0:02                     ` Hui Zhu
2013-05-28  3:36                       ` Yao Qi
2013-05-29 10:08                         ` Hui Zhu
2013-06-03  4:07                       ` Hui Zhu
2013-06-03 17:48                         ` Pedro Alves
2013-06-07  3:16                           ` Hui Zhu
2013-06-17  7:36                             ` Hui Zhu
2013-06-18 18:16                             ` Pedro Alves
2013-06-24  8:36                               ` Hui Zhu
2013-06-24 22:06                                 ` Pedro Alves
2013-06-25  9:14                                   ` Hui Zhu
2013-06-25 11:47                                     ` Pedro Alves
2013-06-25 13:02                                       ` Hui Zhu
2013-06-25 14:06                                         ` Pedro Alves
2013-06-26  2:54                                           ` Hui Zhu
2013-05-22 14:04                   ` Tom Tromey
2013-02-22 17:39 ` DPrintf feedback (was: [RFC] PR 15075 dprintf interferes with "next") Marc Khouzam
2013-02-22 19:32   ` DPrintf feedback Tom Tromey
2013-02-22 20:37     ` Marc Khouzam
2013-02-26 21:12       ` Marc Khouzam
2013-02-28 15:32 ` [PATCH 1/4] Fix dprintf bugs Yao Qi
2013-02-28 13:17   ` [PATCH 2/4] Test case of conditional dprintf Yao Qi
2013-02-28 13:17   ` [PATCH 3/4] Test dprintf breakpoint works correctly with other breakpoints Yao Qi
2013-02-28 14:48   ` [PATCH 4/4] Test case on setting dprintf commands Yao Qi
2013-02-28 16:30   ` [PATCH 1/4] Fix dprintf bugs Eli Zaretskii
2013-03-07  7:45     ` Yao Qi
2013-03-03  2:21   ` Marc Khouzam
2013-03-07  6:47     ` Yao Qi
2013-03-07 14:06       ` Marc Khouzam
2013-03-07 14:36         ` Yao Qi
2013-03-07 14:49           ` Marc Khouzam
2013-03-07 14:59             ` Yao Qi
2013-03-08 15:49               ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738wpd3qe.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox