Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: remove trace_kludge global
Date: Tue, 12 Mar 2013 14:12:00 -0000	[thread overview]
Message-ID: <8738w0k8r1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <513EA1B0.6000005@codesourcery.com> (Yao Qi's message of "Tue, 12	Mar 2013 11:32:00 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> ... 'trace_string' should be zero here.  On the other hand, when
Yao> eval' is true, we are evaluating the result of the expression, so no
Yao> tracing stuff should be involved.  So, we don't have to add the new
Yao> argument 'trace_string' to gen_eval_for_expr, and set
Yao> ax-> trace_string' to zero inside gen_eval_for_expr, and the callers of
Yao> gen_eval_for_expr are not updated.

Thanks for looking at this.
I'll update the patch.

Tom


  reply	other threads:[~2013-03-12 14:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 19:27 Tom Tromey
2013-03-12  3:33 ` Yao Qi
2013-03-12 14:12   ` Tom Tromey [this message]
2013-03-12 15:40     ` Tom Tromey
2013-03-13  8:48       ` Yao Qi
2013-03-21 16:15       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738w0k8r1.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox