From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99438-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10919 invoked by alias); 12 Mar 2013 14:12:37 -0000
Received: (qmail 10899 invoked by uid 22791); 12 Mar 2013 14:12:34 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 14:12:12 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CEC4x2013963	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 12 Mar 2013 10:12:04 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2CEC2fC007064	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 12 Mar 2013 10:12:03 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: remove trace_kludge global
References: <87k3pdn3es.fsf@fleche.redhat.com>	<513EA1B0.6000005@codesourcery.com>
Date: Tue, 12 Mar 2013 14:12:00 -0000
In-Reply-To: <513EA1B0.6000005@codesourcery.com> (Yao Qi's message of "Tue, 12	Mar 2013 11:32:00 +0800")
Message-ID: <8738w0k8r1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00514.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> ... 'trace_string' should be zero here.  On the other hand, when
Yao> eval' is true, we are evaluating the result of the expression, so no
Yao> tracing stuff should be involved.  So, we don't have to add the new
Yao> argument 'trace_string' to gen_eval_for_expr, and set
Yao> ax-> trace_string' to zero inside gen_eval_for_expr, and the callers of
Yao> gen_eval_for_expr are not updated.

Thanks for looking at this.
I'll update the patch.

Tom