From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 14/16] import gnulib sys_wait module
Date: Thu, 14 Nov 2013 21:04:00 -0000 [thread overview]
Message-ID: <8738mywvbs.fsf@fleche.redhat.com> (raw)
In-Reply-To: <834n7p75xj.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Nov 2013 20:15:20 +0200")
Eli> Once again: gnulib's sys_wait.h is wrong for MinGW. This:
I had thought from the earlier series that you didn't think it was
important, but I looked a bit more and I agree, we can't use this.
For example, charset.c uses WIFEXITED -- and it assumes a
tradition-unix-like definition, because that is what pex uses.
Now, it seems to me that it would be preferable if all use of wait.h and
associated macros was limited to various "nat" files. However, that's a
bigger change than I want to get into with this series.
I'm going to drop this patch and the one to remove gdb_wait.h.
Tom
next prev parent reply other threads:[~2013-11-14 21:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 17:11 [PATCH v2 00/16] use gnulib more heavily Tom Tromey
2013-11-06 17:11 ` [PATCH v2 01/16] link gdbreplay against gnulib Tom Tromey
2013-11-06 17:12 ` [PATCH v2 04/16] remove gdb_string.h Tom Tromey
2013-11-06 17:12 ` [PATCH v2 02/16] change how list of modules is computed Tom Tromey
2013-11-18 18:23 ` Pedro Alves
2013-11-18 18:52 ` Tom Tromey
2013-11-06 17:13 ` [PATCH v2 03/16] import strstr and strerror modules Tom Tromey
2013-11-06 17:14 ` [PATCH v2 09/16] stdlib.h is universal too Tom Tromey
2013-11-06 17:25 ` [PATCH v2 14/16] import gnulib sys_wait module Tom Tromey
2013-11-06 19:03 ` Eli Zaretskii
2013-11-14 21:04 ` Tom Tromey [this message]
2013-11-15 7:41 ` Eli Zaretskii
2013-11-06 17:27 ` [PATCH v2 08/16] don't check for stddef.h Tom Tromey
2013-11-06 17:37 ` [PATCH v2 10/16] don't check for unistd.h Tom Tromey
2013-11-06 17:38 ` [PATCH v2 15/16] conditionally define __WCLONE Tom Tromey
2013-11-14 21:56 ` Tom Tromey
2013-11-18 18:59 ` Pedro Alves
2013-11-18 19:21 ` Tom Tromey
2013-11-06 17:43 ` [PATCH v2 11/16] sys/types.h cleanup Tom Tromey
2013-11-06 18:15 ` [PATCH v2 07/16] remove gdb_dirent.h Tom Tromey
2013-11-06 19:04 ` [PATCH v2 13/16] remove gdb_stat.h Tom Tromey
2013-11-06 19:04 ` [PATCH v2 05/16] don't check for string.h or strings.h Tom Tromey
2013-11-06 19:05 ` [PATCH v2 16/16] remove gdb_wait.h Tom Tromey
2013-11-06 19:05 ` [PATCH v2 06/16] import gnulib dirent module Tom Tromey
2013-11-06 19:26 ` [PATCH v2 12/16] import gnulib sys/stat.h module Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mywvbs.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox