From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27556 invoked by alias); 14 Nov 2013 21:02:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27520 invoked by uid 89); 14 Nov 2013 21:02:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 21:02:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAEL2X9C023360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Nov 2013 16:02:33 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAEL2W8Y025205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 14 Nov 2013 16:02:32 -0500 From: Tom Tromey To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 14/16] import gnulib sys_wait module References: <1383757800-6332-1-git-send-email-tromey@redhat.com> <1383757800-6332-15-git-send-email-tromey@redhat.com> <834n7p75xj.fsf@gnu.org> Date: Thu, 14 Nov 2013 21:04:00 -0000 In-Reply-To: <834n7p75xj.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Nov 2013 20:15:20 +0200") Message-ID: <8738mywvbs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00391.txt.bz2 Eli> Once again: gnulib's sys_wait.h is wrong for MinGW. This: I had thought from the earlier series that you didn't think it was important, but I looked a bit more and I agree, we can't use this. For example, charset.c uses WIFEXITED -- and it assumes a tradition-unix-like definition, because that is what pex uses. Now, it seems to me that it would be preferable if all use of wait.h and associated macros was limited to various "nat" files. However, that's a bigger change than I want to get into with this series. I'm going to drop this patch and the one to remove gdb_wait.h. Tom