From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: stanshebs@earthlink.net, gdb-patches@sourceware.org
Subject: Re: [PATCH] Doxygenate defs.h
Date: Tue, 18 Feb 2014 11:37:00 -0000 [thread overview]
Message-ID: <8738jg4pj1.fsf@oracle.com> (raw)
In-Reply-To: <201402172217.s1HMHOAT001833@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Mon, 17 Feb 2014 23:17:24 +0100 (CET)")
> This is a first patch that modifies source code to be more useful with
> Doxygen. It does little more than add an extra "*" to comment blocks
> that document the source construct immediately following.
>
> In keeping with our usual practice, I have not changed anything outside
> comments, and the comments themselves are only minimally tweaked,
> despite the great temptation to expand on some of the more cryptic. :-)
>
> I'll push this in a couple days if people are willing to live with this
> format for comments. Next up, minsyms.h.
Sorry, no, I'm not willing to live with this. It's making the
comments significantly harder to read. And what benefit does the
documentation have over just reading the header file? There really is
only one thing that the old internals documentation tried to provide
that the comments in the source code aren't very good at: explaining
how the interfaces work together. And that's not something Doxygen is
going to provide.
I am of the same opinion. Usually only managers ever "use"
Doxygen-generated "documentation" of C programs, and mostly only because
it is required as a deliverable by contractual reasons.
Most developers will just open the header files and read them, using
some indexing tool (ctags, CEDET/Emacs, whatever Eclipse uses..) for
jumping through references. IMO polluting the comments like this,
restating the obvious with marks like @param, will only make them more
difficult to read with no practical benefit: what gdb hacker will ever
fire up a Firefox or similar to find out what the parameters to some
function are?
If the decision to use Doxygen has been already taken, would it be
possible to at least avoid these @param marks?
next prev parent reply other threads:[~2014-02-18 11:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:57 Stan Shebs
2014-02-17 22:17 ` Mark Kettenis
2014-02-18 11:37 ` Jose E. Marchesi [this message]
2014-02-18 14:14 ` Simon Marchi
2014-02-19 1:47 ` Yao Qi
2014-02-18 19:52 ` Stan Shebs
2014-02-18 23:38 ` Doug Evans
2014-02-19 0:08 ` Stan Shebs
2014-02-26 0:02 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738jg4pj1.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox