From: Yao Qi <yao@codesourcery.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
<stanshebs@earthlink.net>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Doxygenate defs.h
Date: Wed, 19 Feb 2014 01:47:00 -0000 [thread overview]
Message-ID: <53040CB3.4020001@codesourcery.com> (raw)
In-Reply-To: <8738jg4pj1.fsf@oracle.com>
On 02/18/2014 07:40 PM, Jose E. Marchesi wrote:
> Most developers will just open the header files and read them, using
> some indexing tool (ctags, CEDET/Emacs, whatever Eclipse uses..) for
> jumping through references. IMO polluting the comments like this,
> restating the obvious with marks like @param, will only make them more
> difficult to read with no practical benefit: what gdb hacker will ever
> fire up a Firefox or similar to find out what the parameters to some
> function are?
I feel @param is useful here. "@param arg" is equivalent to "ARG" we
are using in comments nowadays, but more descriptive, IMO. It should
not confuse any GDB newbie. Some refactor tools can update @param when
argument is renamed, to keep comments consistent with code.
We use doxygen to generate internal documentation from source code, not
only function comments, but also general overview of each 'module'. It
isn't hard to understand each function comments but hard to get a big
picture of each 'module'. Doxygen helps!
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-02-19 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:57 Stan Shebs
2014-02-17 22:17 ` Mark Kettenis
2014-02-18 11:37 ` Jose E. Marchesi
2014-02-18 14:14 ` Simon Marchi
2014-02-19 1:47 ` Yao Qi [this message]
2014-02-18 19:52 ` Stan Shebs
2014-02-18 23:38 ` Doug Evans
2014-02-19 0:08 ` Stan Shebs
2014-02-26 0:02 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53040CB3.4020001@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=mark.kettenis@xs4all.nl \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox