From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: [RFA] Fix leak in linespec.c
Date: Wed, 09 Jan 2019 00:40:00 -0000 [thread overview]
Message-ID: <8736q2zmqz.fsf@tromey.com> (raw)
In-Reply-To: <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> (Simon Marchi's message of "Tue, 8 Jan 2019 23:39:40 +0000")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> ... so you are adding the equivalent of the first cleanup.
Oops,sorry about that.
I hope eventually either we have ASAN and perhaps LSAN enabled in
development builds; or that it becomes a lot simpler to run tests under
valgrind... not trying to excuse my error, just trying to see how I
could prevent it next time.
Simon> It would be nice to be able to free the suffix strings in linespec_state_destructor, the
Simon> only problem is that we don't know the size of the canonical_names array at that point.
linespec would definitely benefit from a couple more rounds of C++-ification.
Some of the changes spill out into the rest of gdb though.
Tom
next prev parent reply other threads:[~2019-01-09 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 6:25 Philippe Waroquiers
2019-01-08 23:39 ` Simon Marchi
2019-01-09 0:40 ` Tom Tromey [this message]
2019-01-09 3:26 ` Philippe Waroquiers
2019-01-09 23:10 ` Tom Tromey
2019-01-09 3:35 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736q2zmqz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox